-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid_longitudinal_controller)!: add acceleration feedback block #8325
feat(pid_longitudinal_controller)!: add acceleration feedback block #8325
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
2e7a069
to
e07503c
Compare
b021119
to
6d450f0
Compare
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
6d450f0
to
626b1df
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8325 +/- ##
==========================================
- Coverage 24.10% 24.09% -0.01%
==========================================
Files 1399 1399
Lines 102455 102469 +14
Branches 38921 38924 +3
==========================================
Hits 24695 24695
- Misses 75235 75248 +13
- Partials 2525 2526 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Motsu-san |
603dd13
into
autowarefoundation:main
…utowarefoundation#8325) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…utowarefoundation#8325) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…utowarefoundation#8325) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…utowarefoundation#8325) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…utowarefoundation#8325) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Description
This PR provides an acceleration feedback feature for the pid_longitudinal_controller.
The red allows in the following figure are added by this PR.
![image](https://private-user-images.githubusercontent.com/141538661/361327248-f2258401-329f-489b-8a5f-580adbb294be.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzYyODMsIm5iZiI6MTczOTMzNTk4MywicGF0aCI6Ii8xNDE1Mzg2NjEvMzYxMzI3MjQ4LWYyMjU4NDAxLTMyOWYtNDg5Yi04YTVmLTU4MGFkYmIyOTRiZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDUzMDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMzVhMzE1NTEwM2I2ZmQ5ZDQ4ODVmZmRhNDhjMDhkODExMWNhMDc1ZTUxOThmZTQxMGEwN2YxN2Y0ODNkZjU5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.6PcdsjeR4EEuYvF2CHwhWzYJG2oRbINq6MvtuqoOpOY)
Note that the acceleration feedback gain G_a(s) is set as 0 in the default parameters, autowarefoundation/autoware_launch#1139.
Therefore, no behavior is changed by this PR.
With the current construction of the speed controller, it is difficult to achieve both disturbance tolerance and tracking performance when the response delay of the vehicle is large. In order to better ensure this performance, we have added a block that performs feedback control by looking at acceleration information.
This is because acceleration is closer to the input value to the plant than velocity, and the response is about 90 degrees faster.
Related links
launch PR: autowarefoundation/autoware_launch#1139
How was this PR tested?
psim and tier4 internal tests
Notes for reviewers
None.
Effects on system behavior
None.