Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_localization_rviz_plugin): add visualization of pose with covariance history #8191

Merged
merged 8 commits into from
Aug 29, 2024

Correcting spelling mistakes and adding includes

31e6066
Select commit
Loading
Failed to load commit list.
Merged

feat(tier4_localization_rviz_plugin): add visualization of pose with covariance history #8191

Correcting spelling mistakes and adding includes
31e6066
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Aug 29, 2024 in 34s

CodeScene PR Check

Code Health Quality Gates: OK

Code Health of new files: 9.35

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method pose_with_covariance_history_display.cpp: PoseWithCovarianceHistory::updateShapes
  • Bumpy Road Ahead pose_with_covariance_history_display.cpp: PoseWithCovarianceHistory::updateShapes

Annotations

Check warning on line 280 in common/tier4_localization_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

PoseWithCovarianceHistory::updateShapes has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 280 in common/tier4_localization_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

PoseWithCovarianceHistory::updateShapes has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.