feat(tier4_localization_rviz_plugin): add visualization of pose with covariance history #8191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
@YamatoAndo The maintainer was updated with #8184. After the code owner update, would you please review this PR? |
|
@isamu-takagi Sure! |
YamatoAndo
reviewed
Jul 31, 2024
YamatoAndo
reviewed
Jul 31, 2024
...zation_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp
Outdated
Show resolved
Hide resolved
YamatoAndo
reviewed
Jul 31, 2024
...zation_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.hpp
Outdated
Show resolved
Hide resolved
|
Even though the path checkbox is turned off, the "Arrow" is not being removed. |
YamatoAndo
reviewed
Jul 31, 2024
...zation_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
YamatoAndo
reviewed
Aug 28, 2024
YamatoAndo
reviewed
Aug 28, 2024
...zation_rviz_plugin/src/pose_with_covariance_history/pose_with_covariance_history_display.hpp
Show resolved
Hide resolved
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8191 +/- ##
==========================================
- Coverage 24.10% 24.06% -0.04%
==========================================
Files 1399 1400 +1
Lines 102337 102501 +164
Branches 38870 38884 +14
==========================================
Hits 24668 24668
- Misses 75141 75305 +164
Partials 2528 2528
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YamatoAndo
approved these changes
Aug 29, 2024
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…covariance history (autowarefoundation#8191) * display PoseWithCovariance History Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * Correct spelling errors and year Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * Add arrows clear() Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * Extension to 3D in matrix calculations Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * style(pre-commit): autofix * Correcting spelling mistakes and adding includes Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> --------- Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…covariance history (autowarefoundation#8191) * display PoseWithCovariance History Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * Correct spelling errors and year Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * Add arrows clear() Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * Extension to 3D in matrix calculations Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * style(pre-commit): autofix * Correcting spelling mistakes and adding includes Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> --------- Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add plugin to visualize covariance estimated by NDT scan matching continuously on Rviz.
Related links
None.
How was this PR tested?
Run Autoware in my laptop.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.