Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_mpc_lateral_controller): add timestamp and frame ID to published trajectory #8164

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

In this PR, predicted path calculated using the Frenet coordinate system were added for debug purpose, but they couldn't be visualized in rviz due to missing header information.
added the necessary header information with following modification to resolve this issue.

    frenet_clipped.header.stamp = m_clock->now();
    frenet_clipped.header.frame_id = "map";

How was this PR tested?

tested in psim and confirmed visualization
Screenshot from 2024-07-23 20-28-54

Effects on system behavior

None.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jul 23, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2024
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.14%. Comparing base (1f7122a) to head (8960aeb).
Report is 3 commits behind head on main.

Files Patch % Lines
...ontrol/autoware_mpc_lateral_controller/src/mpc.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8164      +/-   ##
==========================================
- Coverage   29.14%   29.14%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      118145   118158      +13     
  Branches    50854    50856       +2     
==========================================
- Hits        34439    34438       -1     
- Misses      74460    74473      +13     
- Partials     9246     9247       +1     
Flag Coverage Δ *Carryforward flag
differential 18.57% <0.00%> (?)
total 29.14% <ø> (-0.01%) ⬇️ Carriedforward from 1f7122a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 8e9cc35 into autowarefoundation:main Jul 23, 2024
38 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the fix/add_header_info_predicted_trajectory branch July 23, 2024 12:01
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
…ublished trajectory (autowarefoundation#8164)

add timestamp and frame ID to published trajectory

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2024
…ublished trajectory (autowarefoundation#8164)

add timestamp and frame ID to published trajectory

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2024
…ublished trajectory (autowarefoundation#8164) (#1452)

add timestamp and frame ID to published trajectory

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…ublished trajectory (autowarefoundation#8164)

add timestamp and frame ID to published trajectory

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants