Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(geography_utils): prefix package and namespace with autoware #7790

Merged
merged 1 commit into from
Aug 15, 2024

refactor(geography_utils): prefix package and namespace with autoware

b45cae9
Select commit
Loading
Failed to load commit list.
Merged

refactor(geography_utils): prefix package and namespace with autoware #7790

refactor(geography_utils): prefix package and namespace with autoware
b45cae9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 14, 2024 in 34s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.00 (8.83 -> 8.82)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method gnss_poser_core.cpp: GNSSPoser::callback_nav_sat_fix

Annotations

Check warning on line 121 in sensing/gnss_poser/src/gnss_poser_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

GNSSPoser::callback_nav_sat_fix already has high cyclomatic complexity, and now it increases in Lines of Code from 98 to 99. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.