refactor(geography_utils): prefix package and namespace with autoware #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
dcde650 to
24c4368
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7790 +/- ##
==========================================
+ Coverage 23.90% 23.92% +0.01%
==========================================
Files 1380 1387 +7
Lines 101770 101868 +98
Branches 38731 38746 +15
==========================================
+ Hits 24332 24369 +37
- Misses 74992 75004 +12
- Partials 2446 2495 +49
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you very much. I have one question.
According to the documentation, the recommended directory structure is autoware_{name}/include/autoware/{name}, but in this pull request, it seems to be autoware_geography_utils/include/autoware_geography_utils. Is this intentional?
isamu-takagi
approved these changes
Jul 3, 2024
|
@SakodaShintaro thanks for pointing that out, working on it. |
01fa936 to
e403aca
Compare
|
@mitsudome-r @youtalk could you have a look at this PR when you have a moment? It's been in the queue for over month and a half. Thanks. |
1 similar comment
|
@mitsudome-r @youtalk could you have a look at this PR when you have a moment? It's been in the queue for over month and a half. Thanks. |
|
We need approval from @kminoda, @kosuke55 and @takayuki5168 but they might be in summer vacation. |
kosuke55
approved these changes
Aug 14, 2024
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
f790bdf to
b45cae9
Compare
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…autowarefoundation#7790) * refactor(geography_utils): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * move headers to include/autoware/ Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> Signed-off-by: xtk8532704 <1041084556@qq.com>
7 tasks
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefix package and namespace with autoware
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.