Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stop_filter): prefix package and namespace with autoware #7789

Merged
merged 2 commits into from
Jul 3, 2024
Merged

refactor(stop_filter): prefix package and namespace with autoware #7789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b94ed03
refactor(stop_filter): prefix package and namespace with autoware
esteve Jul 2, 2024
5859c78
fix launch files and update CODEOWNERS
esteve Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
control/autoware_pid_longitudinal_controller/** mamoru.sobue@tier4.jp takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp
control/autoware_pure_pursuit/** takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp
control/autoware_shift_decider/** takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp
control/autoware_smart_mpc_trajectory_follower/** kosuke.takeuchi@tier4.jp masayuki.aino@proxima-ai-tech.com takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp

Check warning on line 58 in .github/CODEOWNERS

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (masayuki)

Check warning on line 58 in .github/CODEOWNERS

View workflow job for this annotation

GitHub Actions / spell-check-differential 

Unknown word (aino)
control/autoware_trajectory_follower_base/** takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp
control/autoware_trajectory_follower_node/** takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp
control/autoware_vehicle_cmd_gate/** takamasa.horibe@tier4.jp tomoya.kimura@tier4.jp
Expand All @@ -81,6 +81,7 @@
localization/autoware_landmark_based_localizer/autoware_ar_tag_based_localizer/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/autoware_landmark_based_localizer/autoware_landmark_manager/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/autoware_pose_covariance_modifier/** melike@leodrive.ai
localization/autoware_stop_filter/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/ekf_localizer/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp takamasa.horibe@tier4.jp takeshi.ishita@tier4.jp yamato.ando@tier4.jp
localization/geo_pose_projector/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/gyro_odometer/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
Expand All @@ -91,7 +92,6 @@
localization/pose_estimator_arbiter/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/pose_initializer/** anh.nguyen.2@tier4.jp isamu.takagi@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/pose_instability_detector/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/stop_filter/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/twist2accel/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/yabloc/yabloc_common/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
localization/yabloc/yabloc_image_processing/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
Expand Down
2 changes: 1 addition & 1 deletion ...4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</group>

<group>
<include file="$(find-pkg-share stop_filter)/launch/stop_filter.launch.xml">
<include file="$(find-pkg-share autoware_stop_filter)/launch/stop_filter.launch.xml">
<arg name="use_twist_with_covariance" value="True"/>
<arg name="input_odom_name" value="/localization/pose_twist_fusion_filter/kinematic_state"/>
<arg name="input_twist_with_covariance_name" value="/localization/pose_twist_fusion_filter/twist_with_covariance"/>
Expand Down
3 changes: 2 additions & 1 deletion localization/stop_filter/CMakeLists.txt → ...ation/autoware_stop_filter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
cmake_minimum_required(VERSION 3.14)
project(stop_filter)
project(autoware_stop_filter)

find_package(autoware_cmake REQUIRED)
autoware_package()

ament_auto_add_library(${PROJECT_NAME} SHARED
src/stop_filter.cpp
src/stop_filter.hpp
)

rclcpp_components_register_node(${PROJECT_NAME}
Expand Down
0 localization/stop_filter/README.md → localization/autoware_stop_filter/README.md
View file
Open in desktop
File renamed without changes.
0 ...stop_filter/config/stop_filter.param.yaml → ...stop_filter/config/stop_filter.param.yaml
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...stop_filter/launch/stop_filter.launch.xml → ...stop_filter/launch/stop_filter.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<launch>
<arg name="param_path" default="$(find-pkg-share stop_filter)/config/stop_filter.param.yaml"/>
<arg name="param_path" default="$(find-pkg-share autoware_stop_filter)/config/stop_filter.param.yaml"/>
<arg name="input_odom_name" default="ekf_odom"/>
<arg name="output_odom_name" default="stop_filter_odom"/>
<arg name="debug_stop_flag" default="debug/stop_flag"/>
<node pkg="stop_filter" exec="stop_filter_node" output="both">
<node pkg="autoware_stop_filter" exec="autoware_stop_filter_node" output="both">
<remap from="input/odom" to="$(var input_odom_name)"/>

<remap from="output/odom" to="$(var output_odom_name)"/>
Expand Down
2 changes: 1 addition & 1 deletion localization/stop_filter/package.xml → ...lization/autoware_stop_filter/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>stop_filter</name>
<name>autoware_stop_filter</name>
<version>0.0.0</version>
<description>The stop filter package</description>
<maintainer email="koji.minoda@tier4.jp">Koji Minoda</maintainer>
Expand Down
0 ...top_filter/schema/stop_filter.schema.json → ...top_filter/schema/stop_filter.schema.json
View file
Open in desktop
File renamed without changes.
7 changes: 5 additions & 2 deletions localization/stop_filter/src/stop_filter.cpp → .../autoware_stop_filter/src/stop_filter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include "stop_filter/stop_filter.hpp"
#include "stop_filter.hpp"

#include <rclcpp/logging.hpp>

Expand All @@ -24,6 +24,8 @@

using std::placeholders::_1;

namespace autoware::stop_filter
{
StopFilter::StopFilter(const rclcpp::NodeOptions & node_options)
: rclcpp::Node("stop_filter", node_options)
{
Expand Down Expand Up @@ -57,6 +59,7 @@
pub_stop_flag_->publish(stop_flag_msg);
pub_odom_->publish(odom_msg);
}
} // namespace autoware::stop_filter

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(StopFilter)
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::stop_filter::StopFilter)

Check warning on line 65 in localization/autoware_stop_filter/src/stop_filter.cpp

View check run for this annotation

Codecov / codecov/patch

localization/autoware_stop_filter/src/stop_filter.cpp#L65 

Added line #L65 was not covered by tests
9 changes: 6 additions & 3 deletions ...ilter/include/stop_filter/stop_filter.hpp → .../autoware_stop_filter/src/stop_filter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef STOP_FILTER__STOP_FILTER_HPP_
#define STOP_FILTER__STOP_FILTER_HPP_
#ifndef STOP_FILTER_HPP_
#define STOP_FILTER_HPP_

#include <rclcpp/rclcpp.hpp>

Expand All @@ -34,6 +34,8 @@
#include <string>
#include <vector>

namespace autoware::stop_filter
{
class StopFilter : public rclcpp::Node
{
public:
Expand All @@ -54,4 +56,5 @@ class StopFilter : public rclcpp::Node
*/
void callback_odometry(const nav_msgs::msg::Odometry::SharedPtr msg);
};
#endif // STOP_FILTER__STOP_FILTER_HPP_
} // namespace autoware::stop_filter
#endif // STOP_FILTER_HPP_
Loading