Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stop_filter): prefix package and namespace with autoware #7789

Merged
merged 2 commits into from
Jul 3, 2024
Merged

refactor(stop_filter): prefix package and namespace with autoware #7789

merged 2 commits into from
Jul 3, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 2, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 2, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (82d86dc) to head (5859c78).

Files Patch % Lines
...alization/autoware_stop_filter/src/stop_filter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7789      +/-   ##
==========================================
- Coverage   28.55%   28.55%   -0.01%     
==========================================
  Files        1586     1587       +1     
  Lines      115879   115899      +20     
  Branches    49362    49362              
==========================================
  Hits        33094    33094              
- Misses      73745    73765      +20     
  Partials     9040     9040
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.55% <ø> (ø) Carriedforward from 82d86dc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the prefix-stop_filter branch from b328353 to 4b266d4 Compare July 2, 2024 11:03
@esteve esteve changed the title refactor(livox_tag_filter): prefix package and namespace with autoware refactor(stop_filter): prefix package and namespace with autoware Jul 2, 2024
@esteve esteve mentioned this pull request Jul 2, 2024
Open
@esteve esteve marked this pull request as ready for review July 2, 2024 12:11
@esteve esteve enabled auto-merge (squash) July 2, 2024 12:20
SakodaShintaro
SakodaShintaro requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I think the two launch files need to be changed as well.

$(find-pkg-share stop_filter) -> $(find-pkg-share autoware_stop_filter)

  • in localization/autoware_stop_filter/launch/stop_filter.launch.xml

autoware.universe/localization/autoware_stop_filter/launch/stop_filter.launch.xml

Line 2 in 4b266d4

<arg name="param_path" default="$(find-pkg-share stop_filter)/config/stop_filter.param.yaml"/>

  • in launch/tier4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml

autoware.universe/launch/tier4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml

Line 20 in 598eca1

<include file="$(find-pkg-share stop_filter)/launch/stop_filter.launch.xml">

@esteve esteve marked this pull request as draft July 3, 2024 09:00
auto-merge was automatically disabled July 3, 2024 09:00

Pull request was converted to draft

@esteve esteve marked this pull request as ready for review July 3, 2024 09:04
@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

@SakodaShintaro fixed in 662e0f7

@github-actions github-actions bot added type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 3, 2024
SakodaShintaro
SakodaShintaro approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well.
Looks Good To Me 👍

@SakodaShintaro
Copy link
Contributor

There are errors with cppcheck, but it seems that they will be fixed by merging the latest main branch.

@esteve esteve enabled auto-merge (squash) July 3, 2024 10:46
esteve added 2 commits July 3, 2024 13:08
@esteve
refactor(stop_filter): prefix package and namespace with autoware
b94ed03 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix launch files and update CODEOWNERS
5859c78 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the prefix-stop_filter branch from 662e0f7 to 5859c78 Compare July 3, 2024 11:08
@esteve esteve merged commit fbbc44c into autowarefoundation:main Jul 3, 2024
29 of 30 checks passed
@esteve esteve deleted the prefix-stop_filter branch July 3, 2024 11:13
SakodaShintaro added a commit to SakodaShintaro/autoware.universe that referenced this pull request Jul 4, 2024
@SakodaShintaro
Revert "refactor(stop_filter): prefix package and namespace with auto…
c5911f3 
…ware (autowarefoundation#7789)"

This reverts commit fbbc44c.
This was referenced Jul 4, 2024
Closed
Merged
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
@esteve @palas21
refactor(stop_filter): prefix package and namespace with autoware (au…
d573d65 
…towarefoundation#7789)

* refactor(stop_filter): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* fix launch files and update CODEOWNERS

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
@esteve @tby-udel
refactor(stop_filter): prefix package and namespace with autoware (au…
fb6c0eb 
…towarefoundation#7789)

* refactor(stop_filter): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* fix launch files and update CODEOWNERS

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@esteve
refactor(stop_filter): prefix package and namespace with autoware (#7789
f9407c6 
)

* refactor(stop_filter): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* fix launch files and update CODEOWNERS

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@esteve @Ariiees
refactor(stop_filter): prefix package and namespace with autoware (au…
f96ad28 
…towarefoundation#7789)

* refactor(stop_filter): prefix package and namespace with autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* fix launch files and update CODEOWNERS

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@kminoda kminoda Awaiting requested review from kminoda

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @SakodaShintaro