Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix failure condition when modified files are empty #7704

Merged
merged 8 commits into from
Jun 26, 2024
Merged

chore(ci): fix failure condition when modified files are empty #7704

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43fb48e
chore(ci): fix failure condition when modified files are empty
HansRobo Jun 26, 2024
3936143
chore: delete unnecessary new line
HansRobo Jun 26, 2024
3b8bcb3
chore: delete lidar_centerpoint_tvm package for test
HansRobo Jun 26, 2024
6a89898
chore(ci): fix workflow conditions
HansRobo Jun 26, 2024
63d4da2
chore(ci): filter un-existing files in cppcheck-differential
HansRobo Jun 26, 2024
981afbd
Revert "chore: delete lidar_centerpoint_tvm package for test"
HansRobo Jun 26, 2024
32605e4
Merge branch 'main' into fix-failure-condition
HansRobo Jun 26, 2024
e6b37c6
chore: fix pre-commit errors
HansRobo Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/cppcheck-differential.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,20 @@ jobs:
run: git fetch origin ${{ github.base_ref }}
shell: bash

- name: Get changed files
id: changed-files
- name: Get modified files
id: get-modified-files
run: |
git diff --name-only "origin/${{ github.base_ref }}"...HEAD > changed_files.txt
cat changed_files.txt
echo "changed_files=$(git diff --name-only "origin/${{ github.base_ref }}"...HEAD | grep -E '\.(cpp|hpp)$' | tr '\n' ' ' || true)" >> $GITHUB_OUTPUT
shell: bash

HansRobo marked this conversation as resolved.
Show resolved Hide resolved
- name: Run Cppcheck on changed files
continue-on-error: true
id: cppcheck
run: |
files=$(cat changed_files.txt | grep -E '\.(cpp|hpp)$' || true)
if [ -n "$files" ]; then
echo "Running Cppcheck on changed files: $files"
cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --suppressions-list=.cppcheck_suppressions $files 2> cppcheck-report.txt
echo "Running Cppcheck on changed files: ${{ steps.get-modified-files.outputs.changed_files }}"
cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --suppressions-list=.cppcheck_suppressions ${{ steps.get-modified-files.outputs.changed_files }} 2> cppcheck-report.txt
else
echo "No C++ files changed."
touch cppcheck-report.txt
Expand All @@ -63,5 +62,5 @@ jobs:
path: cppcheck-report.txt

- name: Fail the job if Cppcheck failed
if: steps.cppcheck.outcome == 'failure'
if: ${{ steps.get-modified-files.outputs.changed_files != '' && steps.cppcheck.outcome == 'failure' }}
run: exit 1
Loading