chore(ci): fix failure condition when modified files are empty #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
HansRobo
commented
Jun 26, 2024
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
|
@HansRobo |
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
This reverts commit 3b8bcb3.
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
veqcc
approved these changes
Jun 26, 2024
|
@HansRobo |
|
@veqcc I set DCO to pass manually. |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…arefoundation#7704) * chore(ci): fix failure condition when modified files are empty Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete unnecessary new line Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete lidar_centerpoint_tvm package for test Signed-off-by: GitHub <noreply@github.com> * chore(ci): fix workflow conditions Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(ci): filter un-existing files in cppcheck-differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * Revert "chore: delete lidar_centerpoint_tvm package for test" This reverts commit 3b8bcb3. * chore: fix pre-commit errors Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…arefoundation#7704) * chore(ci): fix failure condition when modified files are empty Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete unnecessary new line Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete lidar_centerpoint_tvm package for test Signed-off-by: GitHub <noreply@github.com> * chore(ci): fix workflow conditions Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(ci): filter un-existing files in cppcheck-differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * Revert "chore: delete lidar_centerpoint_tvm package for test" This reverts commit 3b8bcb3. * chore: fix pre-commit errors Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: GitHub <noreply@github.com>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…arefoundation#7704) * chore(ci): fix failure condition when modified files are empty Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete unnecessary new line Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete lidar_centerpoint_tvm package for test Signed-off-by: GitHub <noreply@github.com> * chore(ci): fix workflow conditions Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(ci): filter un-existing files in cppcheck-differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * Revert "chore: delete lidar_centerpoint_tvm package for test" This reverts commit 3b8bcb3. * chore: fix pre-commit errors Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…arefoundation#7704) * chore(ci): fix failure condition when modified files are empty Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete unnecessary new line Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete lidar_centerpoint_tvm package for test Signed-off-by: GitHub <noreply@github.com> * chore(ci): fix workflow conditions Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(ci): filter un-existing files in cppcheck-differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * Revert "chore: delete lidar_centerpoint_tvm package for test" This reverts commit 3b8bcb3. * chore: fix pre-commit errors Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: GitHub <noreply@github.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* chore(ci): fix failure condition when modified files are empty Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete unnecessary new line Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: delete lidar_centerpoint_tvm package for test Signed-off-by: GitHub <noreply@github.com> * chore(ci): fix workflow conditions Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(ci): filter un-existing files in cppcheck-differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * Revert "chore: delete lidar_centerpoint_tvm package for test" This reverts commit 3b8bcb3. * chore: fix pre-commit errors Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failure condition when modified files are empty in
cppcheck-differential.Related links
A test due to empty modified files. (the PR deletes all the package files)
https://github.com/autowarefoundation/autoware.universe/actions/runs/9673888348/job/26688603324
How was this PR tested?
The workflow works well with diffs that includes deleted files only.
https://github.com/HansRobo/autoware.universe/actions/runs/9675016733/job/26691735752
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.