Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix redundantAssignment warning #7560

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(behavior_path_planner): fix redundantAssignment warning #7560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ing/behavior_path_planner/autoware_behavior_path_planner_common/test/test_turn_signal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,7 @@
intersection_signal_info.required_end_point.orientation = createQuaternionFromYaw(0.0);

TurnSignalInfo behavior_signal_info;
behavior_signal_info.turn_signal.command = TurnIndicatorsCommand::ENABLE_RIGHT;

Check notice on line 340 in planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_turn_signal.cpp

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Large Method 

TEST:BehaviorPathPlanningTurnSignal:Condition3 decreases from 117 to 116 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
behavior_signal_info.turn_signal.command = TurnIndicatorsCommand::ENABLE_RIGHT;
behavior_signal_info.desired_start_point.position = createPoint(5.0, 0.0, 0.0);
behavior_signal_info.desired_start_point.orientation = createQuaternionFromYaw(0.0);
behavior_signal_info.desired_end_point.position = createPoint(70.0, 0.0, 0.0);
Expand Down
Loading