Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix redundantAssignment warning #7560

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 18, 2024

Description

This is a fix based on cppcheck redundantAssignment warning

planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_turn_signal.cpp:341:44: style: Variable 'behavior_signal_info.turn_signal.command' is reassigned a value before the old one has been used. [redundantAssignment]
  behavior_signal_info.turn_signal.command = TurnIndicatorsCommand::ENABLE_RIGHT;
                                           ^
planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_turn_signal.cpp:340:44: note: behavior_signal_info.turn_signal.command is assigned
  behavior_signal_info.turn_signal.command = TurnIndicatorsCommand::ENABLE_RIGHT;
                                           ^
planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_turn_signal.cpp:341:44: note: behavior_signal_info.turn_signal.command is overwritten
  behavior_signal_info.turn_signal.command = TurnIndicatorsCommand::ENABLE_RIGHT;
                                           ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 18, 2024
@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 18, 2024
@shmpwk shmpwk enabled auto-merge (squash) June 18, 2024 11:16
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.11%. Comparing base (507e3f4) to head (c4ff758).
Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7560      +/-   ##
==========================================
- Coverage   14.84%   13.11%   -1.74%     
==========================================
  Files        1999      524    -1475     
  Lines      139163    48672   -90491     
  Branches    43716    11793   -31923     
==========================================
- Hits        20661     6381   -14280     
+ Misses      95731    41348   -54383     
+ Partials    22771      943   -21828     
Flag Coverage Δ
differential 13.11% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk shmpwk merged commit 7493322 into autowarefoundation:main Jun 18, 2024
38 of 40 checks passed
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…foundation#7560)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants