Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system_diagnostic_monitor): fix local mode config #7532

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jun 17, 2024

Description

Since local commands are published from other than joy_controller, such as tier4_control_rviz_plugin, fix diagnostic graph.

Tests performed

Launch planning simulator and check that the operation mode can be changed to local/remote.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 17, 2024
@isamu-takagi isamu-takagi self-assigned this Jun 18, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review June 18, 2024 06:32
@isamu-takagi isamu-takagi requested a review from kosuke55 June 18, 2024 07:36
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
I confirmed that I can push local button and use manual control rviz plugin

image

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 18, 2024
@kosuke55 kosuke55 merged commit 4094bbf into autowarefoundation:main Jun 18, 2024
37 of 38 checks passed
@isamu-takagi isamu-takagi deleted the fix/local-mode-diag branch June 18, 2024 12:11
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…tion#7532)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
shtokuda pushed a commit to tier4/autoware.universe that referenced this pull request Jul 11, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants