Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bpp): add prefix autoware_ #7288

Merged
merged 14 commits into from
Jun 6, 2024
Merged

chore(bpp): add prefix autoware_ #7288

merged 14 commits into from
Jun 6, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 6, 2024 •
edited by xmfcx
Loading

Description

rename package to autoware_behavior_path_planner_common from behavior_path_planner_common.

Part of:

Tests performed

grep -R -w behavior_path_planner_common planning

Effects on system behavior

Nothing.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 6, 2024
@satoshi-ota satoshi-ota added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 6, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 6, 2024
@satoshi-ota satoshi-ota force-pushed the chore/add-prefix-bpp-common branch from 97e63dc to 0a097ff Compare June 6, 2024 00:47
@satoshi-ota satoshi-ota removed the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@satoshi-ota satoshi-ota force-pushed the chore/add-prefix-bpp-common branch from 0a097ff to f051d39 Compare June 6, 2024 00:48
@satoshi-ota satoshi-ota removed request for knzo25 and kminoda June 6, 2024 00:48
satoshi-ota added 10 commits June 6, 2024 10:09
@satoshi-ota
fix(side_shift): fix header
8bdd35a 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(sampling_planner): fix header
9172170 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(start_planner): fix header
db0e582 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(goal_planner): fix header
dc719fa 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(lane_change): fix header
567248b 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(external_lane_change): fix header
83ce5d1 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(AbLC): fix header
c3cdab1 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(bpp-node): fix header
037f670 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(static_centerline_generator): fix header
1334f50 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(.pages): update link
98aad65 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the chore/add-prefix-bpp-common branch from 2abda21 to 98aad65 Compare June 6, 2024 01:09
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) June 6, 2024 02:14
@satoshi-ota
Copy link
Contributor Author

We can ignore this error in pre-commit-optional.

Markdown Link Check......................................................Failed
- hook id: markdown-link-check
- exit code: 1


  ERROR: 1 dead links found in planning/autoware_behavior_path_planner_common/docs/behavior_path_planner_path_generation_design.md !
  [✖] https://github.com/autowarefoundation/autoware.universe/blob/main/planning/autoware_behavior_path_planner_common/include/autoware_behavior_path_planner_common/utils/path_shifter/path_shifter.hpp → Status: 404

@tkimura4
Copy link
Contributor

tkimura4 commented Jun 6, 2024

@satoshi-ota
Do you also need to make changes to the
CODEOWNER file?

(Ref. https://github.com/autowarefoundation/autoware.universe/pull/6639/files )

@satoshi-ota
Copy link
Contributor Author

satoshi-ota commented Jun 6, 2024 •
edited
Loading

@tkimura4 Oh. You're right. I'll add a commit. (Fortunatelly, the build ci doesn't run yet.)

-> 8ae64bd

@satoshi-ota
fix: update codeowner
8ae64bd 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 6, 2024
@satoshi-ota satoshi-ota merged commit 09b0c40 into autowarefoundation:main Jun 6, 2024
22 of 25 checks passed
@satoshi-ota satoshi-ota deleted the chore/add-prefix-bpp-common branch June 6, 2024 07:20
@SakodaShintaro SakodaShintaro mentioned this pull request Jun 6, 2024
Merged
7 tasks
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jun 6, 2024
@satoshi-ota @kminoda
chore(bpp): add prefix autoware_ (autowarefoundation#7288)
9fe10f2 
* chore(common): rename package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_obstacle_avoidance): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(dynamic_obstacle_avoidance): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(side_shift): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(sampling_planner): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(start_planner): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(goal_planner): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(lane_change): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(external_lane_change): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(AbLC): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp-node): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_centerline_generator): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(.pages): update link

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@xmfcx xmfcx mentioned this pull request Jun 6, 2024
Open
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@satoshi-ota
chore(bpp): add prefix autoware_ (#7288)
056b84f 
* chore(common): rename package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_obstacle_avoidance): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(dynamic_obstacle_avoidance): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(side_shift): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(sampling_planner): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(start_planner): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(goal_planner): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(lane_change): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(external_lane_change): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(AbLC): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp-node): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_centerline_generator): fix header

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(.pages): update link

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@danielsanchezaran danielsanchezaran danielsanchezaran approved these changes

@soblin soblin soblin approved these changes

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@kosuke55 kosuke55 kosuke55 approved these changes

@tkimura4 tkimura4 tkimura4 approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

@shmpwk shmpwk Awaiting requested review from shmpwk

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@go-sakayori go-sakayori Awaiting requested review from go-sakayori

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@satoshi-ota @tkimura4 @rej55 @danielsanchezaran @soblin @kyoichi-sugahara @kosuke55 @maxime-clem