-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(object_lanelet_filter): add velocity direction based object lanelet filter #7107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
requested review from
badai-nguyen,
Shin-kyoto,
miursh and
yukkysaito
as code owners
May 23, 2024 17:13
github-actions
bot
added
the
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
label
May 23, 2024
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 23, 2024
4 tasks
yukkysaito
approved these changes
May 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…let filter (autowarefoundation#7107) * chore: refactor lanelet filter function Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add lanelet direction filter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: do not change default settings Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: skip orientation unavailable objects Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: feature variable name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 3, 2024
…let filter (autowarefoundation#7107) * chore: refactor lanelet filter function Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add lanelet direction filter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: do not change default settings Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: skip orientation unavailable objects Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: feature variable name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
This was referenced Jun 3, 2024
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…let filter (autowarefoundation#7107) * chore: refactor lanelet filter function Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add lanelet direction filter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: do not change default settings Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: skip orientation unavailable objects Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: feature variable name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
7 tasks
4 tasks
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…let filter (#7107) * chore: refactor lanelet filter function Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add lanelet direction filter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: do not change default settings Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: skip orientation unavailable objects Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: feature variable name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates lanelet filter so that it can filter objects with opposite velocity toward belonging lanelet.
New filter will check if:
merge launcher PR first.
Here shows the example that filter opposite directed car.
Related links
https://tier4.atlassian.net/browse/RT0-31022
Tests performed
Tested with Lsim.
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.