Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_lanelet_filter): add velocity direction based object lanelet filter #7107

Merged
merged 5 commits into from
May 30, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented May 23, 2024

Description

This PR updates lanelet filter so that it can filter objects with opposite velocity toward belonging lanelet.
New filter will check if:

  • object has valid velocity larger than threshold (defalt: 3.0 m/s)
  • object velocity direction does not differ with its lanelet (default 45 deg)

merge launcher PR first.

Here shows the example that filter opposite directed car.

before after filtered
Screenshot from 2024-05-24 02-08-53 Screenshot from 2024-05-24 02-08-58

Related links

https://tier4.atlassian.net/browse/RT0-31022

Tests performed

Tested with Lsim.

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshiRi added 2 commits May 24, 2024 00:29
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 23, 2024
YoshiRi added 2 commits May 24, 2024 02:15
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 23, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi merged commit 1b5a6b2 into main May 30, 2024
22 of 23 checks passed
@YoshiRi YoshiRi deleted the feat/update_object_lanelet_filter branch May 30, 2024 05:28
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…let filter (autowarefoundation#7107)

* chore: refactor lanelet filter function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add lanelet direction filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: do not change default settings

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: skip orientation unavailable objects

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: feature variable name

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Jun 3, 2024
…let filter (autowarefoundation#7107)

* chore: refactor lanelet filter function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add lanelet direction filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: do not change default settings

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: skip orientation unavailable objects

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: feature variable name

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…let filter (autowarefoundation#7107)

* chore: refactor lanelet filter function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add lanelet direction filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: do not change default settings

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: skip orientation unavailable objects

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: feature variable name

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…let filter (#7107)

* chore: refactor lanelet filter function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: add lanelet direction filter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: do not change default settings

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat: skip orientation unavailable objects

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: feature variable name

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants