Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freespace_planner): fix motion_velocity_smoother error while parking #6713

fix(freespace_planner): mark flag with true when trajectory is less t…

01bfb5a
Select commit
Loading
Failed to load commit list.
Merged

fix(freespace_planner): fix motion_velocity_smoother error while parking #6713

fix(freespace_planner): mark flag with true when trajectory is less t…
01bfb5a
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 9, 2024 in 47s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Bumpy Road Ahead freespace_planner_node.cpp: FreespacePlannerNode::onTimer

Annotations

Check notice on line 497 in planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Complex Method

FreespacePlannerNode::onTimer increases in cyclomatic complexity from 14 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 497 in planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

FreespacePlannerNode::onTimer has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.