Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): add general turnsignalinfo method for goal planner #6629

Conversation

danielsanchezaran
Copy link
Contributor

Description

Implements the changes of #6625 for the Goal Planner module's turnSignalInfo calculation into the Avoidance module. Please see original PR for a bigger description: https://github.com/autowarefoundation/autoware.universe/pull/6622/files

This PR is 1 out of 5 and depends on this PR: #6625

The idea is to implement the general method for getting the turn signal into the start,goal,avoidance and LC modules.

Related links

Tests performed

See https://github.com/autowarefoundation/autoware.universe/pull/6622/files

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 26, 2024
@danielsanchezaran danielsanchezaran enabled auto-merge (squash) March 26, 2024 09:06
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 14.77%. Comparing base (6ee9627) to head (8191430).
Report is 41 commits behind head on main.

Files Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6629      +/-   ##
==========================================
- Coverage   14.79%   14.77%   -0.02%     
==========================================
  Files        1920     1920              
  Lines      132398   132525     +127     
  Branches    39345    39345              
==========================================
  Hits        19582    19582              
- Misses      90970    91097     +127     
  Partials    21846    21846              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 6ee9627

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit 297b486 into autowarefoundation:main Mar 26, 2024
33 of 36 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/goal-planner-add-general-calc-turn-signal-method branch March 26, 2024 09:45
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request May 24, 2024
autowarefoundation#6629)

add general turnsignalinfo method for goal planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#6629)

add general turnsignalinfo method for goal planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
saka1-s added a commit to tier4/autoware.universe that referenced this pull request Jun 4, 2024
…g turn signal for bpp modules v0.19.1 (#1313)

* feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules (autowarefoundation#6625)

add general method for calculating turn signal for bpp modules

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(behavior_path_avoidance_module): use the general calc turn signal method (autowarefoundation#6626)

use the general calc turn signal method

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(lane_change_module): add general method to get turn signal for LC module (autowarefoundation#6627)

add general method to get turn signal for LC module

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(start_planner): add general turn signal method to start planner (autowarefoundation#6628)

* Add general turnSignal method to start planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add description to ignore signal

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(goal_planner): add general turnsignalinfo method for goal planner (autowarefoundation#6629)

add general turnsignalinfo method for goal planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* resolve merge conflict

* add turn_signal_remaining_shift_length_threshold

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* include utility header to use std::pair

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp>
Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants