-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planner): add general turnsignalinfo method for goal planner #6629
Merged
danielsanchezaran
merged 1 commit into
autowarefoundation:main
from
tier4:feat/goal-planner-add-general-calc-turn-signal-method
Mar 26, 2024
Merged
feat(goal_planner): add general turnsignalinfo method for goal planner #6629
danielsanchezaran
merged 1 commit into
autowarefoundation:main
from
tier4:feat/goal-planner-add-general-calc-turn-signal-method
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
7 tasks
soblin
approved these changes
Mar 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6629 +/- ##
==========================================
- Coverage 14.79% 14.77% -0.02%
==========================================
Files 1920 1920
Lines 132398 132525 +127
Branches 39345 39345
==========================================
Hits 19582 19582
- Misses 90970 91097 +127
Partials 21846 21846
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
297b486
into
autowarefoundation:main
33 of 36 checks passed
4 tasks
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
May 24, 2024
autowarefoundation#6629) add general turnsignalinfo method for goal planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
autowarefoundation#6629) add general turnsignalinfo method for goal planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
saka1-s
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 4, 2024
…g turn signal for bpp modules v0.19.1 (#1313) * feat(behavior_path_planner_common): add general method for calculating turn signal for bpp modules (autowarefoundation#6625) add general method for calculating turn signal for bpp modules Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(behavior_path_avoidance_module): use the general calc turn signal method (autowarefoundation#6626) use the general calc turn signal method Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(lane_change_module): add general method to get turn signal for LC module (autowarefoundation#6627) add general method to get turn signal for LC module Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(start_planner): add general turn signal method to start planner (autowarefoundation#6628) * Add general turnSignal method to start planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add description to ignore signal Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(goal_planner): add general turnsignalinfo method for goal planner (autowarefoundation#6629) add general turnsignalinfo method for goal planner Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * resolve merge conflict * add turn_signal_remaining_shift_length_threshold Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * include utility header to use std::pair --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the changes of #6625 for the Goal Planner module's turnSignalInfo calculation into the Avoidance module. Please see original PR for a bigger description: https://github.com/autowarefoundation/autoware.universe/pull/6622/files
This PR is 1 out of 5 and depends on this PR: #6625
The idea is to implement the general method for getting the turn signal into the start,goal,avoidance and LC modules.
Related links
Tests performed
See https://github.com/autowarefoundation/autoware.universe/pull/6622/files
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.