Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again #6468

Merged

Conversation

TomohitoAndo
Copy link
Contributor

Description

In the current implementation, the decision to proceed is made individually for each traffic signal. As a result, the ego vehicle sometimes moves forward even when a signal message is not received.
To address this issue, I introduced a variable that tracks whether a signal message has been received. Now, if a signal message is received but a subsequent traffic signal message is not, the ego vehicle will stop.

simplescreenrecorder-2024-02-21_15.33.29.mp4

image

Related

TIER IV INTERNAL LINK

Tests performed

I conducted tests in simple planning simulator.
In the following video, if the traffic signal of 1008 has once received, the stop point is inserted to the traffic signal of 1002 because the signal for it is not received.

simplescreenrecorder-2024-02-21_15.17.05.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…nce received, is not received again."

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 21, 2024
@TomohitoAndo TomohitoAndo changed the title feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again. feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again Feb 21, 2024
@TomohitoAndo TomohitoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (871f8f2) 15.10% compared to head (ee82014) 15.10%.
Report is 10 commits behind head on main.

Files Patch % Lines
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6468   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files        1823     1823           
  Lines      126292   126294    +2     
  Branches    38188    38189    +1     
=======================================
+ Hits        19075    19076    +1     
- Misses      85826    85827    +1     
  Partials    21391    21391           
Flag Coverage Δ *Carryforward flag
differential 11.59% <33.33%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from 518cda6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo
Copy link
Contributor Author

I updated comments for more clarity.
ee82014

@TomohitoAndo TomohitoAndo enabled auto-merge (squash) February 22, 2024 00:55
@TomohitoAndo TomohitoAndo merged commit c50a5e2 into autowarefoundation:main Feb 22, 2024
22 of 23 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/stop-when-no-signal branch February 26, 2024 06:17
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Feb 26, 2024
…nce received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Feb 28, 2024
…nce received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…nce received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 4, 2024
…nce received, is not received again (autowarefoundation#6468) (#1156)

feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."



* add comments for clarity



* fix comments for clarity



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…nce received, is not received again (#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 11, 2024
…nce received, is not received again (autowarefoundation#6468) (#1156)

feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."



* add comments for clarity



* fix comments for clarity



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…nce received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments for clarity

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants