-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again #6468
Merged
TomohitoAndo
merged 3 commits into
autowarefoundation:main
from
TomohitoAndo:feat/stop-when-no-signal
Feb 22, 2024
Merged
feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again #6468
TomohitoAndo
merged 3 commits into
autowarefoundation:main
from
TomohitoAndo:feat/stop-when-no-signal
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce received, is not received again." Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6468 +/- ##
=======================================
Coverage 15.10% 15.10%
=======================================
Files 1823 1823
Lines 126292 126294 +2
Branches 38188 38189 +1
=======================================
+ Hits 19075 19076 +1
- Misses 85826 85827 +1
Partials 21391 21391
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Feb 21, 2024
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
I updated comments for more clarity. |
satoshi-ota
approved these changes
Feb 22, 2024
shmpwk
approved these changes
Feb 22, 2024
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 26, 2024
…nce received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 28, 2024
…nce received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…nce received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 4, 2024
…nce received, is not received again (autowarefoundation#6468) (#1156) feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." * add comments for clarity * fix comments for clarity --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Merged
4 tasks
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…nce received, is not received again (#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 11, 2024
…nce received, is not received again (autowarefoundation#6468) (#1156) feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." * add comments for clarity * fix comments for clarity --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…nce received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix comments for clarity Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current implementation, the decision to proceed is made individually for each traffic signal. As a result, the ego vehicle sometimes moves forward even when a signal message is not received.
To address this issue, I introduced a variable that tracks whether a signal message has been received. Now, if a signal message is received but a subsequent traffic signal message is not, the ego vehicle will stop.
simplescreenrecorder-2024-02-21_15.33.29.mp4
Related
TIER IV INTERNAL LINK
Tests performed
I conducted tests in simple planning simulator.
In the following video, if the traffic signal of 1008 has once received, the stop point is inserted to the traffic signal of 1002 because the signal for it is not received.
simplescreenrecorder-2024-02-21_15.17.05.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.