Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): initially ignore occlusion at intersection with tl, if tl info has never been available #6273

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 1, 2024

Description

depends #6272

this PR affects only intersections with traffic lights.

for the convenience of Psim users and scenario files, if no corresponding traffic light information is published for the associated traffic light, it is treated as "RED" and it only runs collision checking.

Related links

Tests performed

tested by setting enable.occlusion to true

until [00:58], no traffic signal information is published, so only collision is checked initially because traffic light is not published.

at [00:58] traffic light is published, so occlusion detection becomes effective and ego starts peeking and then stops.

at [02:10] the color is GREEN and intersection_occlusion is effective, but after that it turns YELLOW/RED, and intersection_occlusion is ignore.

PR6273-2024-02-02_19.38.31.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 1, 2024
Copy link

mergify bot commented Feb 1, 2024

⚠️ The sha of the head commit of this PR conflicts with #6272. Mergify cannot evaluate rules on this PR. ⚠️

2 similar comments
Copy link

mergify bot commented Feb 2, 2024

⚠️ The sha of the head commit of this PR conflicts with #6272. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

mergify bot commented Feb 2, 2024

⚠️ The sha of the head commit of this PR conflicts with #6272. Mergify cannot evaluate rules on this PR. ⚠️

@soblin soblin force-pushed the feat/intersection/ignore-occ-with-tl-if-no-tl-info branch 2 times, most recently from 35bff84 to a927cd5 Compare February 2, 2024 10:25
@soblin soblin changed the title feat(intersection): ignore occlusion at intersection with tl initially, if no tl info has been available feat(intersection): initially ignore occlusion at intersection with tl, if tl info has never been available Feb 2, 2024
@soblin soblin force-pushed the feat/intersection/ignore-occ-with-tl-if-no-tl-info branch from a927cd5 to 24b6744 Compare February 2, 2024 10:32
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/ignore-occ-with-tl-if-no-tl-info branch from 24b6744 to ee83469 Compare February 2, 2024 10:51
@soblin soblin marked this pull request as ready for review February 2, 2024 10:52
@soblin soblin enabled auto-merge (squash) February 2, 2024 10:57
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (fa8424d) 14.37% compared to head (ee83469) 14.36%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 30 Missing ⚠️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% 24 Missing ⚠️
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 11 Missing ⚠️
...ection_module/src/scene_intersection_occlusion.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6273      +/-   ##
==========================================
- Coverage   14.37%   14.36%   -0.01%     
==========================================
  Files        1907     1907              
  Lines      130072   130108      +36     
  Branches    37618    37639      +21     
==========================================
  Hits        18695    18695              
- Misses      90367    90402      +35     
- Partials    21010    21011       +1     
Flag Coverage Δ *Carryforward flag
differential 4.63% <0.00%> (?)
total 14.37% <ø> (+<0.01%) ⬆️ Carriedforward from fa8424d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit c89f863 into autowarefoundation:main Feb 2, 2024
19 of 22 checks passed
@soblin soblin deleted the feat/intersection/ignore-occ-with-tl-if-no-tl-info branch February 2, 2024 12:04
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…l, if tl info has never been available (autowarefoundation#6273)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…l, if tl info has never been available (autowarefoundation#6273)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants