-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): initially ignore occlusion at intersection with tl, if tl info has never been available #6273
Conversation
|
2 similar comments
|
|
35bff84
to
a927cd5
Compare
a927cd5
to
24b6744
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
24b6744
to
ee83469
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6273 +/- ##
==========================================
- Coverage 14.37% 14.36% -0.01%
==========================================
Files 1907 1907
Lines 130072 130108 +36
Branches 37618 37639 +21
==========================================
Hits 18695 18695
- Misses 90367 90402 +35
- Partials 21010 21011 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…l, if tl info has never been available (autowarefoundation#6273) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…l, if tl info has never been available (autowarefoundation#6273) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
depends #6272
this PR affects only intersections with traffic lights.
for the convenience of Psim users and scenario files, if no corresponding traffic light information is published for the associated traffic light, it is treated as "RED" and it only runs collision checking.
Related links
Tests performed
tested by setting
enable.occlusion
to trueuntil [00:58], no traffic signal information is published, so only collision is checked initially because traffic light is not published.
at [00:58] traffic light is published, so occlusion detection becomes effective and ego starts peeking and then stops.
at [02:10] the color is GREEN and intersection_occlusion is effective, but after that it turns YELLOW/RED, and intersection_occlusion is ignore.
PR6273-2024-02-02_19.38.31.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.