Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(start_planner): calculate drivable lanes efficiently #6105

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 17, 2024

Description

drivable_lanes is calculated when shift path is planned every times.
But drivable_lanes is identical to the current pose so calculate them outside of ShiftPullOut one time.

another motivation for the change is to visualize expanded drivable lanes for debug reason

Tests performed

test with psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 17, 2024
pre-commit-ci bot and others added 3 commits January 17, 2024 11:42
…fficiently

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/calculate_expanded_drivable_lanes_efficiently branch from 6cd1904 to fd075ac Compare January 18, 2024 04:03
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review January 18, 2024 04:14
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start_planner): calculate expanded drivable lanes efficiently refactor(start_planner): calculate drivable lanes efficiently Jan 18, 2024
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/calculate_expanded_drivable_lanes_efficiently branch from 4922dba to 9421314 Compare January 18, 2024 06:18
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 18, 2024
…fficiently

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (c2de78d) 14.60% compared to head (61a0851) 14.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 20 Missing ⚠️
...avior_path_start_planner_module/shift_pull_out.hpp 0.00% 2 Missing ⚠️
...r_path_start_planner_module/src/shift_pull_out.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6105      +/-   ##
==========================================
- Coverage   14.60%   14.60%   -0.01%     
==========================================
  Files        1860     1860              
  Lines      127325   127338      +13     
  Branches    37276    37276              
==========================================
  Hits        18598    18598              
- Misses      87810    87823      +13     
  Partials    20917    20917              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.60% <ø> (+<0.01%) ⬆️ Carriedforward from c2de78d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit bbf678d into autowarefoundation:main Jan 20, 2024
20 of 24 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/calculate_expanded_drivable_lanes_efficiently branch January 20, 2024 06:09
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…refoundation#6105)

* Refactor ShiftPullOut class and update expanded drivable lanes

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Refactor drivable lane functions

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Fix lane departure check in ShiftPullOut::plan()

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants