-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(start_planner): calculate drivable lanes efficiently #6105
refactor(start_planner): calculate drivable lanes efficiently #6105
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
6cd1904
to
fd075ac
Compare
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
4922dba
to
9421314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…fficiently Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…fficiently Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6105 +/- ##
==========================================
- Coverage 14.60% 14.60% -0.01%
==========================================
Files 1860 1860
Lines 127325 127338 +13
Branches 37276 37276
==========================================
Hits 18598 18598
- Misses 87810 87823 +13
Partials 20917 20917
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bbf678d
into
autowarefoundation:main
…refoundation#6105) * Refactor ShiftPullOut class and update expanded drivable lanes Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor drivable lane functions Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Fix lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Description
drivable_lanes
is calculated when shift path is planned every times.But
drivable_lanes
is identical to the current pose so calculate them outside ofShiftPullOut
one time.another motivation for the change is to visualize expanded drivable lanes for debug reason
Tests performed
test with psim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.