-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior velocity planner modules #6094
Merged
kyoichi-sugahara
merged 18 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/add_enable_all_modules_auto_mode_behavior_velocity
Jan 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…r_velocity_modules Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4
approved these changes
Jan 17, 2024
rej55
approved these changes
Jan 17, 2024
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…or_velocity Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…able_all_modules_auto_mode_behavior_velocity
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…able_all_modules_auto_mode_behavior_velocity
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
9ca460a
to
b140412
Compare
…or_velocity Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6094 +/- ##
=======================================
Coverage 15.17% 15.17%
=======================================
Files 1770 1770
Lines 122580 122579 -1
Branches 37276 37275 -1
=======================================
Hits 18597 18597
Misses 83065 83065
+ Partials 20918 20917 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
94357d2
into
autowarefoundation:main
21 of 24 checks passed
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2024
…ument to launch files for behavior velocity planner modules (autowarefoundation#6094) * set default value for enable_all_modules_auto_mode Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix enable_rtc configuration in scene_module_manager_interface.hpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor scene module managers to use getEnableRTC function Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
4 tasks
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2024
* feat(behavior_path_planner): add enable_all_modules_auto_mode argument to launch files for behavior path planner modules (autowarefoundation#6093) * Add enable_all_modules_auto_mode argument to launch files Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * set default value for enable_all_modules_auto_mode Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix enable_rtc configuration in scene_module_manager_interface.hpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior velocity planner modules (autowarefoundation#6094) * set default value for enable_all_modules_auto_mode Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix enable_rtc configuration in scene_module_manager_interface.hpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor scene module managers to use getEnableRTC function Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ument to launch files for behavior velocity planner modules (autowarefoundation#6094) * set default value for enable_all_modules_auto_mode Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix enable_rtc configuration in scene_module_manager_interface.hpp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Refactor scene module managers to use getEnableRTC function Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following PRs shold be merged first
#6093
autowarefoundation/autoware_launch#798
auto_mode is controlled by parameter of enable_rtc
Independing on those parameter,
enable all module's auto_mode by adding
enable_all_modules_auto_mode:=true
when you launch autowareTests performed
with auto_mode for intersection module is disabled
confirmed auto_mode is disabled
![image](https://private-user-images.githubusercontent.com/32741405/297048048-ee51893e-039b-40d8-805b-6151e6818972.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDc4MjUsIm5iZiI6MTczOTM0NzUyNSwicGF0aCI6Ii8zMjc0MTQwNS8yOTcwNDgwNDgtZWU1MTg5M2UtMDM5Yi00MGQ4LTgwNWItNjE1MWU2ODE4OTcyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA4MDUyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmYjlkODMzMDdjZDg0ZDJiNDVkMGNiMzkxYWY3MTQwMzBlN2JkMmZmMmJkNWIzNGExZGM5N2ZjZGY3ZjFlMTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.tWW_AjNGwh8l9iIqkGejmYrSZwM1_8W8y6FPJepEbwE)
with launch argument of
![image](https://private-user-images.githubusercontent.com/32741405/297044282-5a6e79b3-fcf5-44ec-bc56-bc93192757cf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDc4MjUsIm5iZiI6MTczOTM0NzUyNSwicGF0aCI6Ii8zMjc0MTQwNS8yOTcwNDQyODItNWE2ZTc5YjMtZmNmNS00NGVjLWJjNTYtYmM5MzE5Mjc1N2NmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA4MDUyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEwNjUxYWU0NzMxYTgzOGI2MmIxZDg1MGJjMmZiMzEwZTlkNjE4MmM0YTViYmFjMDU2MjEwODdlNzk2M2JjZTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.G2Sr2T0Ykelf9aiJa5lCgmiGxUvXwT8cAMH5HzIbLaw)
enable_all_modules_auto_mode:=true
confirmed auto_mode is enabled
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.