Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior velocity planner modules #6094

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 16, 2024

Description

Following PRs shold be merged first
#6093
autowarefoundation/autoware_launch#798

auto_mode is controlled by parameter of enable_rtc

  • this is parameter for behavior_path_planner modules
  • this is one example fort behavior_belocity_planner modules

Independing on those parameter,
enable all module's auto_mode by adding enable_all_modules_auto_mode:=true when you launch autoware

Tests performed

with auto_mode for intersection module is disabled

      enable_rtc:
        intersection: true

confirmed auto_mode is disabled
image

with launch argument of enable_all_modules_auto_mode:=true
confirmed auto_mode is enabled
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…r_velocity_modules

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 16, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review January 16, 2024 12:53
@satoshi-ota satoshi-ota self-assigned this Jan 17, 2024
@tkimura4 tkimura4 changed the title feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior vfelocity planner modules feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior velocity planner modules Jan 17, 2024
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2024
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…or_velocity

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…able_all_modules_auto_mode_behavior_velocity
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…able_all_modules_auto_mode_behavior_velocity
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/add_enable_all_modules_auto_mode_behavior_velocity branch from 9ca460a to b140412 Compare January 19, 2024 07:25
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4379781) 15.17% compared to head (afa5e7f) 15.17%.

Files Patch % Lines
...avior_velocity_intersection_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
...ehavior_velocity_blind_spot_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
...behavior_velocity_crosswalk_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
...ior_velocity_detection_area_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
...r_velocity_no_stopping_area_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
...vior_velocity_traffic_light_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6094   +/-   ##
=======================================
  Coverage   15.17%   15.17%           
=======================================
  Files        1770     1770           
  Lines      122580   122579    -1     
  Branches    37276    37275    -1     
=======================================
  Hits        18597    18597           
  Misses      83065    83065           
+ Partials    20918    20917    -1     
Flag Coverage Δ *Carryforward flag
differential 12.14% <0.00%> (?)
total 15.17% <ø> (+<0.01%) ⬆️ Carriedforward from 4379781

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 94357d2 into autowarefoundation:main Jan 20, 2024
21 of 24 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/add_enable_all_modules_auto_mode_behavior_velocity branch January 20, 2024 06:07
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2024
…ument to launch files for behavior velocity planner modules (autowarefoundation#6094)

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Refactor scene module managers to use getEnableRTC function

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2024
* feat(behavior_path_planner): add enable_all_modules_auto_mode argument to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior velocity planner modules (autowarefoundation#6094)

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Refactor scene module managers to use getEnableRTC function

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ument to launch files for behavior velocity planner modules (autowarefoundation#6094)

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Refactor scene module managers to use getEnableRTC function

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants