feat(multi_object_tracker): mot bicycle model revision #6082
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 5 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Overall Function Size bicycle_tracker.cpp
- Large Method bicycle_tracker.cpp: BicycleTracker::BicycleTracker
- Large Method big_vehicle_tracker.cpp: BigVehicleTracker::getTrackedObject
- Large Method normal_vehicle_tracker.cpp: NormalVehicleTracker::getTrackedObject
- Large Method bicycle_tracker.cpp: BicycleTracker::getTrackedObject
✅ Improving Code Health:
- Complex Method normal_vehicle_tracker.cpp: NormalVehicleTracker::measureWithPose
- Large Method normal_vehicle_tracker.cpp: NormalVehicleTracker::NormalVehicleTracker
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
BigVehicleTracker::getTrackedObject increases from 76 to 87 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in perception/multi_object_tracker/src/tracker/model/big_vehicle_tracker.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.11 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 1 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Overall Function Size
The median function size in this module is 69.0 LOC, threshold = 50.0. This file contains overly long functions, measured by their lines of code.
Check warning on line 147 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
BicycleTracker::BicycleTracker increases from 87 to 89 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 547 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
BicycleTracker::getTrackedObject increases from 70 to 81 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in perception/multi_object_tracker/src/tracker/model/bicycle_tracker.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.57 to 5.29, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
NormalVehicleTracker::measureWithPose decreases in cyclomatic complexity from 19 to 17, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Large Method
NormalVehicleTracker::NormalVehicleTracker decreases from 101 to 100 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
NormalVehicleTracker::getTrackedObject increases from 76 to 87 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.50 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.