-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml #6071
Merged
takayuki5168
merged 2 commits into
autowarefoundation:main
from
tier4:feat/static-centerline-optimizer-behavior-vel-interval
Jan 16, 2024
Merged
feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml #6071
takayuki5168
merged 2 commits into
autowarefoundation:main
from
tier4:feat/static-centerline-optimizer-behavior-vel-interval
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th interval from yaml Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
814cd8f
to
39d7df6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6071 +/- ##
==========================================
- Coverage 14.66% 14.66% -0.01%
==========================================
Files 1858 1858
Lines 126603 126606 +3
Branches 37157 37160 +3
==========================================
Hits 18564 18564
Misses 87167 87167
- Partials 20872 20875 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kosuke55
approved these changes
Jan 16, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…th interval from yaml (autowarefoundation#6071) * feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…th interval from yaml (autowarefoundation#6071) * feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…th interval from yaml (autowarefoundation#6071) * feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…th interval from yaml (autowarefoundation#6071) * feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior_velocity_planner's path interval was recently extracted from the hard code to the yaml file.
The static_centerline_optimizer package depends on the originally hard-coded parameter.
This PR makes the static_centerline_optimizer to load the parameter from the yaml file.
Tests performed
Unit test
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.