Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml #6071

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 14, 2024

Description

The behavior_velocity_planner's path interval was recently extracted from the hard code to the yaml file.
The static_centerline_optimizer package depends on the originally hard-coded parameter.

This PR makes the static_centerline_optimizer to load the parameter from the yaml file.

Tests performed

Unit test

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 14, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 14, 2024 18:06
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 14, 2024
…th interval from yaml

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/static-centerline-optimizer-behavior-vel-interval branch from 814cd8f to 39d7df6 Compare January 15, 2024 17:08
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6e550fc) 14.66% compared to head (39d7df6) 14.66%.

Files Patch % Lines
...optimizer/src/static_centerline_optimizer_node.cpp 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6071      +/-   ##
==========================================
- Coverage   14.66%   14.66%   -0.01%     
==========================================
  Files        1858     1858              
  Lines      126603   126606       +3     
  Branches    37157    37160       +3     
==========================================
  Hits        18564    18564              
  Misses      87167    87167              
- Partials    20872    20875       +3     
Flag Coverage Δ *Carryforward flag
differential 22.65% <0.00%> (?)
total 14.66% <ø> (+<0.01%) ⬆️ Carriedforward from 6e550fc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 2a6dc0e into autowarefoundation:main Jan 16, 2024
20 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/static-centerline-optimizer-behavior-vel-interval branch January 16, 2024 02:10
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…th interval from yaml (autowarefoundation#6071)

* feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…th interval from yaml (autowarefoundation#6071)

* feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…th interval from yaml (autowarefoundation#6071)

* feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…th interval from yaml (autowarefoundation#6071)

* feat(static_centerline_optimizer): get behavior_velocity_planner's path interval from yaml

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants