-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception_benchmark_tool): add perception benchmark tool #603
feat(perception_benchmark_tool): add perception benchmark tool #603
Conversation
@1222-takeshi I approved your review request, but this pull request is still a draft. |
e9c2deb
to
c920d44
Compare
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
c920d44
to
a342974
Compare
…enchmark tool package Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
I shared the initial 3D tracking benchmark results in the README file of the PR link. It contains only the results of the lidar-only pipeline. For running the camera-lidar-fusion pipeline, we need to run it with multiple GPUs, the Waymo dataset contains 5 cameras. After this PR #736, I will add its result. For vehicles, there is no blockage. But for pedestrians, We have some problems. We are giving a constant length and width size to the pedestrian bounding boxes in Autoware.Universe, it's equal to 1 meter. But, Waymo Dataset has so strict 3D IoU scores for matching tracked ground truth objects and tracked object predictions. When we give a fixed size to pedestrians, it falls below the cutoff score. (Vehicle: 0.7 , Pedestrian and Cyclist: 0.5). For this reason, pedestrian scores are almost equal to zero. We can use bounding boxes directly coming from 3D detection nodes just for evaluation but it needs an external change of the perception stack and reproducing benchmarking results could be really hard, or we can change the score threshold from the dataset config file but in this way, we can't compare our results with other. I think there are only 2 options. If you have any suggestions or advice please share them. |
If the current stack is getting 0 points for pedestrians, it's ok. We can work on improving the detection pipeline to increase it later on. @1222-takeshi when can you review this? Will you be able to reproduce the results by following instructions in the readme file? |
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
@kaancolak I believe this benchmark should be placed under "perception" directory. Is there any reason for making benchmark directly at top-level ? |
Thanks, @miursh for your feedback. Actually, I talked to Fatih when I first started this tool, he advised this directory structure. It can also take place in Perception, but some of the developers from the Robotec working on generic evaluation tools, which will contain multiple packages for metric calculation (localization, control, etc. ). We can collect all benchmarking and evaluation tools under a single top-level folder. But this is optional. For now, I think, reproducing benchmarking result of this package is enough. Our goal was the compare our tracking result with other tracking submissions in the Waymo 3D Tracking Challenge. And also, after the generic evaluation tools are finished, I am planning to connect the generic evaluation tools and perception benchmark tools for a more generic evaluator / benchmarking tools. |
@mitsudome-r Sorry not yet. As mentioned above(his reply at 15 days ago), @.kaancolak is trying to update codes. After he gets ready, I will re-review. |
fa0c511
to
6e39032
Compare
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
6e39032
to
2c3ff5d
Compare
@ktro2828, Sorry for the delay, I was dealing with other issues about BUS ODD field tests. I made the updates, the package is now ready to be reviewed. |
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
@kaancolak sorry for late to reaction. I'm reviewing, but build-and-test is failed in CI/CD. Can you fix it?? |
Thanks, I added the license agreement. Currently, Autoware docker doesn't contain TensorFlow but but all data in the Waymo dataset is in TensorFlow "tfrecord" format. For this reason, it doesn't pass the CI/CD pipeline at the moment. |
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
@kenji-miyake What is the right way to have pip packages like
https://github.com/autowarefoundation/autoware.universe/actions/runs/3088532428/jobs/5011962436 here I suspect |
@xmfcx Yes, it is possible. You can send pull requests to add your dependencies here. If you have some troubles with And I believe skipping tests is only acceptable as a tentative workaround. In this case, you should create a follow-up issue. |
I create PR for waymo_open_dataset, a related link. After this PR is merged, waymo_open_dataset will install the relevant TensorFlow version. |
@kaancolak It seems the PR has been merged, so please update package.xml to install waymo-open-dataset with rosdep. |
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
caf3cc5
to
036c873
Compare
And this causes python unit tests to fail. I couldn't find what installs the But if I install waymo with (without @kenji-miyake Is there a clean way to skip If so, I can update the README instructions to install it that way. If not, I will close this PR and add it as a separate repository in |
036c873
to
adc7951
Compare
@kaancolak I guess the dependency of $ docker run --rm -it ubuntu:20.04 /bin/bash
$ apt update && apt install -y python3-pip
$ pip3 install -U -q waymo-open-dataset-tf-2-6-0
$ pip list | grep protobuf
protobuf 4.21.7 Also, build fails on Humble. In that case, you can't merge this PR. $ docker run --rm -it ubuntu:20.04 /bin/bash
$ apt update && apt install -y python3-pip
$ pip3 install -U -q waymo-open-dataset-tf-2-6-0
ERROR: Could not find a version that satisfies the requirement waymo-open-dataset-tf-2-6-0 (from version
s: none) ERROR: No matching distribution found for waymo-open-dataset-tf-2-6-0 |
You can move the contents of this package to https://github.com/autowarefoundation/perception_benchmark_tool |
this PR moved to autowarefoundation/perception_benchmark_tool#1 |
feat: change launch repo to awf/autoware_launch Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat: change repos to latest autoware Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * chore: sync latest (autowarefoundation#505) * fix: fix typo vender -> vendor (autowarefoundation#504) * chore: sync files (autowarefoundation#497) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * fix: use hash for Autoware's Ansible Galaxy (autowarefoundation#506) * chore: remove kvaser role (autowarefoundation#491) * chore: remove kvaser roles (autowarefoundation#145) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix: remove kvaser role (autowarefoundation#146) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * chore: sync files (autowarefoundation#507) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * Update ansible-galaxy-requirements.yaml Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * [repos] add rclcpp to fix server connection failure in scenario test Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix(rclcpp): use humble retry patch branch (autowarefoundation#575) fix(rclcpp): use humble retry patch branch Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat: add sync from awf-latest -> awf-latest-xx1 (autowarefoundation#578) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: change launch repo (autowarefoundation#603) feat: change launch repo to awf/autoware_launch Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: remove unnecessary sync (autowarefoundation#611) * chore: remove unnecessary sync Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add new sync for reference design Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: remove rclcpp hotfix (autowarefoundation#610) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: add eagleye packages in autoware.repos Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * feat: use develop/planning_control scenario_simulator_v2 (autowarefoundation#633) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * chore(repos): update branch of `transport_drivers` (autowarefoundation#636) chore(repos): update repos Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore: update simulator.repos (autowarefoundation#685) update branch of scenario_simulator_v2 from develop/planning_control to master Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * feat: add run_out's stop margin (autowarefoundation#692) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: add j6_gen1 and ymc_golfcart_m0 description (autowarefoundation#693) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * revert: feat: add j6_gen1 and ymc_golfcart_m0 description (autowarefoundation#693) (autowarefoundation#694) Revert "feat: add j6_gen1 and ymc_golfcart_m0 description (autowarefoundation#693)" This reverts commit 46c1046c68e19404f3d430c8775d7c436266e125. * feat: add j6_gen1 and ymc_golfcart_m0 description (autowarefoundation#695) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat: use awf-latest branch for universe and launcher (autowarefoundation#720) * feat: use awf-latest branch for universe and launcher Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update README.md Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * minor update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix spell Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: sync files (autowarefoundation#708) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com> * feat: add get ml model script (autowarefoundation#730) * feat: add get_ml_model script (autowarefoundation#688) * feat: add get_ml_model script Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> * style(pre-commit): autofix * fix: fix pre-commit Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> Co-authored-by: 1222-takeshi <1222-takeshi@users.noreply.github.com> * feat: update model install script (autowarefoundation#690) Signed-off-by: Shin-kyoto <aquashin0202@gmail.com> --------- Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> Signed-off-by: Shin-kyoto <aquashin0202@gmail.com> Co-authored-by: 1222-takeshi <1222-takeshi@users.noreply.github.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> * chore: remove no longer used ml_model_provider repo (autowarefoundation#731) Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * chore: sync files (autowarefoundation#738) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com> * awf pr 4212 Signed-off-by: Mamoru Sobue <hilo.soblin@gmail.com> * feat: update README.md (autowarefoundation#765) * feat: update README.md Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove sync-awf-latest Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix typo Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> Signed-off-by: Shin-kyoto <aquashin0202@gmail.com> Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Signed-off-by: Mamoru Sobue <hilo.soblin@gmail.com> Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: kminoda <kminoda@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Takeshi Miura <m.takeshi1995@gmail.com> Co-authored-by: 1222-takeshi <1222-takeshi@users.noreply.github.com> Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
Signed-off-by: kaancolak kcolak@leodrive.ai
Description
Resolves #565
Builds on top of #565
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.