-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pose_instability_detector to diagnostic_aggregator #5935
feat: add pose_instability_detector to diagnostic_aggregator #5935
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
=======================================
Coverage 15.28% 15.28%
=======================================
Files 1750 1750
Lines 120392 120392
Branches 36729 36729
=======================================
Hits 18404 18404
Misses 81335 81335
Partials 20653 20653
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…efoundation#5935) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…efoundation#5935) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…efoundation#5935) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…efoundation#5935) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Description
#5439
Add pose_instability_detector to diagnostic_aggregator.
We haven't added the diagnostics to the system_error_monitor yet, so Autoware's behavior remains unchanged. ( Even if there's an error in diagnostics, Autoware won't switch to Emergency mode. )
Tests performed
Confirmed that there are no errors in Psim.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.