Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pose_instability_detector to diagnostic_aggregator #5935

Conversation

tkimura4
Copy link
Contributor

Description

#5439
Add pose_instability_detector to diagnostic_aggregator.
We haven't added the diagnostics to the system_error_monitor yet, so Autoware's behavior remains unchanged. ( Even if there's an error in diagnostics, Autoware won't switch to Emergency mode. )

Tests performed

Confirmed that there are no errors in Psim.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from ito-san as a code owner December 22, 2023 05:19
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 22, 2023
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c5f38a) 15.28% compared to head (59d5205) 15.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5935   +/-   ##
=======================================
  Coverage   15.28%   15.28%           
=======================================
  Files        1750     1750           
  Lines      120392   120392           
  Branches    36729    36729           
=======================================
  Hits        18404    18404           
  Misses      81335    81335           
  Partials    20653    20653           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.28% <ø> (ø) Carriedforward from 1c5f38a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ito-san ito-san merged commit 2e2f184 into autowarefoundation:main Dec 22, 2023
32 checks passed
@ito-san ito-san deleted the feat/pose_instability_detector_to_diag_agg branch December 22, 2023 06:51
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants