-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(localization): add pose_instability_detector
#5439
feat(localization): add pose_instability_detector
#5439
Conversation
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
localization/pose_instability_detector/src/pose_instability_detector.cpp
Outdated
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Outdated
Show resolved
Hide resolved
localization/pose_instability_detector/src/pose_instability_detector.cpp
Outdated
Show resolved
Hide resolved
@SakodaShintaro Please update the rqt_runtime_monitor.png to its latest state just before merging. |
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
difference in PoseInstabilityDetector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for comments. It seems that there is a change to launch, so it cannot be merged without the approve of the person who has the authority to do so. |
…on#5439) * Added pose_instability_detector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Renamed files Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed parameter name Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed to launch Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed to run normally Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed to publish diagnostics Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed a variable name Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed Copyright Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added maintainer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added maintainer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Removed log output Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Modified test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed comment Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added a test case Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added set_first_odometry_ Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed test Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed topic name Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed position Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added twist message2 Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed launch Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Updated README.md Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Fixed as pointed out by clang-tidy Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Renamed parameters Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed timer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed README.md Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added debug publishers Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed parameters Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Fixed tests Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Changed the type of ekf_to_odom and add const Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Fixed DiagnosticStatus Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Changed odometry_data to std::optional Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Refactored debug output in pose instability detector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Remove warning message for negative time difference in PoseInstabilityDetector Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Updated rqt_runtime_monitor.png Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Added
pose_instability_detector
node.See README.md for details.
A known problem is that the amount of data published to
/diagnostics
in the current autoware is too large and can cause it to drop some data.Tests performed
The following tests have been run and verified
A directory named
lcov
will be created under~/autoware
, where coverage can be checked.Result
The following results are obtained when run in AWSIM's rosbag.
Effects on system behavior
An output to check the stability of the EKF output values will be added to the diagnostics.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.