Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): fix typo in node yaml parameter #5856

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 13, 2023

Description

Just fix multi_object_tracker node parameter typography

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested a review from yukkysaito as a code owner December 13, 2023 05:23
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 13, 2023
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (705a70d) 15.30% compared to head (f49462a) 15.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5856   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files        1740     1740           
  Lines      119914   119914           
  Branches    36450    36450           
=======================================
  Hits        18351    18351           
  Misses      81028    81028           
  Partials    20535    20535           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.30% <ø> (ø) Carriedforward from 705a70d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 1de8fc5 into autowarefoundation:main Dec 13, 2023
33 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…oundation#5856)

fix: fix typo in node yaml parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…oundation#5856)

fix: fix typo in node yaml parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…oundation#5856)

fix: fix typo in node yaml parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…oundation#5856)

fix: fix typo in node yaml parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…oundation#5856)

fix: fix typo in node yaml parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…oundation#5856)

fix: fix typo in node yaml parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants