Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): move lane change param #5807

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 7, 2023

Description

🤖[deprecated] Generated by Copilot at 9cec5ad

This pull request refactors the behavior path planner code to improve the handling of lane change parameters. It introduces a new LaneChangeParameters struct and a lane_change namespace that contain the lane change specific data and logic. It simplifies the function signatures and reduces the code duplication by passing a LaneChangeParameters object instead of a BehaviorPathPlannerParameters object where appropriate. It also updates the test code and the node parameter server to use the new data structures and namespaces.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 7, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1934 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (9cec5ad) 11.42%.
Report is 174 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/scene.cpp 13.04% 561 Missing and 92 partials ⚠️
...path_avoidance_module/src/shift_line_generator.cpp 12.99% 443 Missing and 66 partials ⚠️
...nning/behavior_path_avoidance_module/src/utils.cpp 3.75% 195 Missing and 10 partials ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 188 Missing ⚠️
...th_avoidance_by_lane_change_module/src/manager.cpp 17.70% 0 Missing and 79 partials ⚠️
...nning/behavior_path_avoidance_module/src/debug.cpp 0.00% 61 Missing ⚠️
...ing/behavior_path_avoidance_module/src/manager.cpp 18.86% 0 Missing and 43 partials ⚠️
...test/test_behavior_path_planner_node_interface.cpp 25.53% 0 Missing and 35 partials ⚠️
..._planner_module/src/default_fixed_goal_planner.cpp 0.00% 34 Missing ⚠️
...test/test_behavior_path_planner_node_interface.cpp 26.66% 0 Missing and 33 partials ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5807       +/-   ##
===========================================
- Coverage   15.32%   11.42%    -3.90%     
===========================================
  Files        1721      111     -1610     
  Lines      118559    15041   -103518     
  Branches    37995     6636    -31359     
===========================================
- Hits        18169     1719    -16450     
+ Misses      79657    10891    -68766     
+ Partials    20733     2431    -18302     
Flag Coverage Δ
differential 11.42% <12.64%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 1f7ad17 into autowarefoundation:main Dec 8, 2023
42 of 45 checks passed
@satoshi-ota satoshi-ota deleted the refactor/move-param-file branch December 8, 2023 08:18
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
* refactor(lane_change): move lane change params

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): remove unnecessary param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants