feat(trtexec_vendor): remove package #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wep21
reviewed
Dec 1, 2023
perception/detected_object_validation/src/object_lanelet_filter.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kminoda <koji.minoda@tier4.jp>
7783145 to
45fc62b
Compare
|
@felixf4xu @xmfcx Our internal process doesn't use |
I use autoware.auto as it has, so I'm fine to remove it. Actually, even outside autoware, I always build and install trtexec with tensorrt installation, I agree it should be removed from autoware. |
xmfcx
approved these changes
Dec 1, 2023
3 tasks
3 tasks
4 tasks
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
Signed-off-by: kminoda <koji.minoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
3 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 26, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 10, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove this package since this is no longer used in ml_model_provider or any other packages in Autoware Universe.
Furthermore, this package includes git clone during CMake, which makes the current
build-and-testCI fail.Tests performed
Should be OK as long as the build succeeds in CI.
Effects on system behavior
No effect expected.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.