-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add glog_component for pointcloud_container #5716
Merged
miursh
merged 1 commit into
autowarefoundation:main
from
badai-nguyen:chore/add_glog_component_into_pointcloud_container
Dec 13, 2023
Merged
chore: add glog_component for pointcloud_container #5716
miursh
merged 1 commit into
autowarefoundation:main
from
badai-nguyen:chore/add_glog_component_into_pointcloud_container
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
YoshiRi
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
miursh
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…n#5716) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…n#5716) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…n#5716) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…n#5716) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…n#5716) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…n#5716) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This to add glog_component for debugging when a node of pointcloud_container crashed.
Tests performed
Confirmed by logging_simulator that glob_component was executed.
![image](https://private-user-images.githubusercontent.com/94814556/286549186-890ca548-7575-4aa5-be2b-36a11e40253f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDc3NjksIm5iZiI6MTczOTU0NzQ2OSwicGF0aCI6Ii85NDgxNDU1Ni8yODY1NDkxODYtODkwY2E1NDgtNzU3NS00YWE1LWJlMmItMzZhMTFlNDAyNTNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1Mzc0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMyOGI3YWU5M2VjZDU1Zjc1ZWM0NjI3MTMxY2NkODU1ZTE1MmFhZTFkN2UzNDBiYWJlZmQ5Nzg3YTMwZDIyOGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ASL2pfed7d8AJDKrCyQHQjUrikZ7cLHFtWWnk-kt2R4)
If an error is added in one of pointcloud_container's node, for example voxel_based_compare_map_filter_nodelet.cpp
sed -i -z 's|pcl::PointCloud<pcl::PointXYZ>::Ptr pcl_output(new pcl::PointCloud<pcl::PointXYZ>);\n|pcl::PointCloud<pcl::PointXYZ>::Ptr pcl_output(new pcl::PointCloud<pcl::PointXYZ>);\n throw std::runtime_error("error!!!!!!!!!!!!!!!!!!");\n|' ./src/universe/autoware.universe/perception/compare_map_segmentation/src/voxel_based_compare_map_filter_nodelet.cpp
It will throw out some stack trace for debugging as bellow
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.