Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add glog_component for pointcloud_container #5716

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Nov 29, 2023

Description

This to add glog_component for debugging when a node of pointcloud_container crashed.

Tests performed

Confirmed by logging_simulator that glob_component was executed.
image

If an error is added in one of pointcloud_container's node, for example voxel_based_compare_map_filter_nodelet.cpp
sed -i -z 's|pcl::PointCloud<pcl::PointXYZ>::Ptr pcl_output(new pcl::PointCloud<pcl::PointXYZ>);\n|pcl::PointCloud<pcl::PointXYZ>::Ptr pcl_output(new pcl::PointCloud<pcl::PointXYZ>);\n throw std::runtime_error("error!!!!!!!!!!!!!!!!!!");\n|' ./src/universe/autoware.universe/perception/compare_map_segmentation/src/voxel_based_compare_map_filter_nodelet.cpp

It will throw out some stack trace for debugging as bellow


[component_container_mt-1] terminate called after throwing an instance of 'std::runtime_error'
[component_container_mt-1]   what():  error!!!!!!!!!!!!!!!!!!
[component_container_mt-1] *** Aborted at 1701252545 (unix time) try "date -d @1701252545" if you are using GNU date ***
[component_container_mt-1] PC: @                0x0 (unknown)
[component_container_mt-1] *** SIGABRT (@0x3e800089a03) received by PID 563715 (TID 0x7fbdd4ff9640) from PID 563715; stack trace: ***
[component_container_mt-1]     @     0x7fbdfc111046 (unknown)
[component_container_mt-1]     @     0x7fbe00442520 (unknown)
[component_container_mt-1]     @     0x7fbe004969fc pthread_kill
[component_container_mt-1]     @     0x7fbe00442476 raise
[component_container_mt-1]     @     0x7fbe004287f3 abort
[component_container_mt-1]     @     0x7fbe008a2b9e (unknown)
[component_container_mt-1]     @     0x7fbe008ae20c (unknown)
[component_container_mt-1]     @     0x7fbe008ae277 std::terminate()
[component_container_mt-1]     @     0x7fbe008ae4d8 __cxa_throw
[component_container_mt-1]     @     0x7fbce4521170 _ZN24compare_map_segmentation35VoxelBasedCompareMapFilterComponent6filterERKSt10shared_ptrIKN11sensor_msgs3msg12PointCloud2_ISaIvEEEERKS1_ISt6vectorIiSaIiEEERS6_.cold
[component_container_mt-1]     @     0x7fbdd1c03144 pointcloud_preprocessor::Filter::computePublish()
[component_container_mt-1]     @     0x7fbdd1c04fd1 pointcloud_preprocessor::Filter::input_indices_callback()
[component_container_mt-1]     @     0x7fbdd1c236bf std::_Function_handler<>::_M_invoke()
[component_container_mt-1]     @     0x7fbdf4470e57 _ZNSt8__detail9__variant17__gen_vtable_implINS0_

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Nov 29, 2023
@badai-nguyen badai-nguyen marked this pull request as ready for review December 12, 2023 09:48
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2023
@miursh miursh enabled auto-merge (squash) December 13, 2023 12:44
@miursh miursh merged commit 7477e9a into autowarefoundation:main Dec 13, 2023
10 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…n#5716)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…n#5716)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants