-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): add objects of interest marker interface #5695
Merged
rej55
merged 1 commit into
autowarefoundation:main
from
rej55:feat/objects_of_interest_marker_for_bpp
Nov 28, 2023
Merged
feat(behavior_path_planner): add objects of interest marker interface #5695
rej55
merged 1 commit into
autowarefoundation:main
from
rej55:feat/objects_of_interest_marker_for_bpp
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
satoshi-ota
approved these changes
Nov 27, 2023
kosuke55
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zulfaqar-azmi-t4
approved these changes
Nov 28, 2023
7 tasks
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…autowarefoundation#5695) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change,
objects_of_interest_marker_interface
is applied only in lane change module.In this PR, I apply it to scene modules in behavior path planner.
(However, setting objects of interest marker data is not enabled except lane change module in this PR)
Related links
Tests performed
TIER IV INTERNAL TEST
Planning simulator
![Screenshot from 2023-11-27 18-43-34](https://private-user-images.githubusercontent.com/10190493/285812986-f1d55845-718b-4531-889d-55f9e073470d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTg1MDMsIm5iZiI6MTczOTM1ODIwMywicGF0aCI6Ii8xMDE5MDQ5My8yODU4MTI5ODYtZjFkNTU4NDUtNzE4Yi00NTMxLTg4OWQtNTVmOWUwNzM0NzBkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMDMyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEwY2RhNmZjMDQ0OWE3NjBlNGI4NjM4YzFjMzhjNmUyMWZhYWY0ZjZmOGI3ZDUwNDI4YjBjNDE2NjM4MmNjMjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Kp4CYktLUSjKX5k4ekI08oslYY8PzYfERKPN19-2mW0)
Notes for reviewers
Interface changes
Objects of interest marker data will be published.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.