Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add objects of interest marker interface #5695

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Nov 27, 2023

Description

Before this change, objects_of_interest_marker_interface is applied only in lane change module.
In this PR, I apply it to scene modules in behavior path planner.

(However, setting objects of interest marker data is not enabled except lane change module in this PR)

Related links

Tests performed

TIER IV INTERNAL TEST

Planning simulator
Screenshot from 2023-11-27 18-43-34

Notes for reviewers

Interface changes

Objects of interest marker data will be published.

/planning/debug/objects_of_interest/**

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 27, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 enabled auto-merge (squash) November 28, 2023 01:45
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1479 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (f50058f) 12.48%.
Report is 79 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 4.27% 169 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.56% 175 Missing and 2 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 84 Missing ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.81% 54 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.62% 53 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 4.44% 41 Missing and 2 partials ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 9.52% 15 Missing and 4 partials ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5695       +/-   ##
===========================================
- Coverage   15.32%   12.48%    -2.85%     
===========================================
  Files        1721      107     -1614     
  Lines      118559    15216   -103343     
  Branches    37995     8526    -29469     
===========================================
- Hits        18169     1899    -16270     
+ Misses      79657    10341    -69316     
+ Partials    20733     2976    -17757     
Flag Coverage Δ
differential 12.48% <11.01%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit da66320 into autowarefoundation:main Nov 28, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants