Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): fix json schema #5676

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 25, 2023

Description

🤖[deprecated] Generated by Copilot at 3fc8a9f

Changed the type of is_publish_debug_path property in behavior_velocity_planner.schema.json from number to boolean. This improves the schema consistency and accuracy, and avoids parsing errors.

Tests performed

See CI/CD result.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 25, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 25, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (3fc8a9f) 27.91%.
Report is 63 commits behind head on main.

Files Patch % Lines
planning/behavior_velocity_planner/src/node.cpp 0.00% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5676       +/-   ##
===========================================
+ Coverage   15.32%   27.91%   +12.58%     
===========================================
  Files        1721        3     -1718     
  Lines      118559      326   -118233     
  Branches    37995      185    -37810     
===========================================
- Hits        18169       91    -18078     
+ Misses      79657       83    -79574     
+ Partials    20733      152    -20581     
Flag Coverage Δ
differential 27.91% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit e76d032 into autowarefoundation:main Nov 26, 2023
@satoshi-ota satoshi-ota deleted the fix/json-bvp branch November 26, 2023 05:23
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants