Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crosswalk_traffic_light_estimator): add operation to remove traffic signals with duplicated ids #5653

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix(crosswalk_traffic_light_estimator): add operation to remove traffic signals with duplicated ids #5653

merged 2 commits into from
Dec 8, 2023

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Nov 22, 2023 •
edited by miursh
Loading

Description

Add operation to remove Traffic Light Signals which has duplicated traffic_signal_id.
Related discussion is #4734 (comment)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 22, 2023
@ktro2828 ktro2828 changed the title fix: add operation to remove traffic signals with duplicated ids fix(traffic_light_multi_camera_fusion): add operation to remove traffic signals with duplicated ids Nov 22, 2023
@miursh
Copy link
Contributor

miursh commented Nov 23, 2023 •
edited
Loading

@ktro2828
I think this should be implemented in crosswalk_traffic_light_estimator.

@ktro2828
Copy link
Contributor Author

@miursh

I think this should be implemented in crosswalk_traffic_light_estimator.

Thanks, I will update!

@ktro2828 ktro2828 changed the title fix(traffic_light_multi_camera_fusion): add operation to remove traffic signals with duplicated ids fix(crosswalk_traffic_light_estimator): add operation to remove traffic signals with duplicated ids Nov 24, 2023
@ktro2828 ktro2828 force-pushed the fix/traffic_light/remove_dupliated_id branch 2 times, most recently from 94b8a0c to 68fd2d8 Compare December 4, 2023 04:50
@ktro2828 ktro2828 marked this pull request as ready for review December 4, 2023 04:50
@ktro2828
Copy link
Contributor Author

ktro2828 commented Dec 4, 2023 •
edited
Loading

@tzhong518 I added operation to remove signals which have duplicated Id. Could you review this?

@ktro2828
fix: add operation to remove traffic signals with duplicated ids
d52a128 
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828
feat: move operation into crosswalk_traffic_light_estimator
11cb033 
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the fix/traffic_light/remove_dupliated_id branch from 68fd2d8 to 11cb033 Compare December 4, 2023 04:52
@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 4, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (11cb033) 0.00%.
Report is 143 commits behind head on main.

Files Patch % Lines
...ion/crosswalk_traffic_light_estimator/src/node.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #5653       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721       1     -1720     
  Lines      118559     169   -118390     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657     169    -79488     
+ Partials    20733       0    -20733
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828 ktro2828 self-assigned this Dec 5, 2023
miursh
miursh approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 795d787 into autowarefoundation:main Dec 8, 2023
31 of 34 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@ktro2828 @danielsanchezaran
fix(crosswalk_traffic_light_estimator): add operation to remove traff…
6de4226 
…ic signals with duplicated ids (autowarefoundation#5653)

* fix: add operation to remove traffic signals with duplicated ids

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* feat: move operation into `crosswalk_traffic_light_estimator`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

---------

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@ktro2828 @karishma1911
fix(crosswalk_traffic_light_estimator): add operation to remove traff…
87138ca 
…ic signals with duplicated ids (autowarefoundation#5653)

* fix: add operation to remove traffic signals with duplicated ids

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* feat: move operation into `crosswalk_traffic_light_estimator`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

---------

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@ktro2828 @karishma1911
fix(crosswalk_traffic_light_estimator): add operation to remove traff…
94a3342 
…ic signals with duplicated ids (autowarefoundation#5653)

* fix: add operation to remove traffic signals with duplicated ids

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* feat: move operation into `crosswalk_traffic_light_estimator`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

---------

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023
Merged
@ktro2828 ktro2828 deleted the fix/traffic_light/remove_dupliated_id branch April 2, 2024 18:04
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@ktro2828 @karishma1911
fix(crosswalk_traffic_light_estimator): add operation to remove traff…
a57d9d5 
…ic signals with duplicated ids (autowarefoundation#5653)

* fix: add operation to remove traffic signals with duplicated ids

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* feat: move operation into `crosswalk_traffic_light_estimator`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

---------

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@ktro2828 @karishma1911
fix(crosswalk_traffic_light_estimator): add operation to remove traff…
0e97ab6 
…ic signals with duplicated ids (autowarefoundation#5653)

* fix: add operation to remove traffic signals with duplicated ids

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* feat: move operation into `crosswalk_traffic_light_estimator`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

---------

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@ktro2828 @karishma1911
fix(crosswalk_traffic_light_estimator): add operation to remove traff…
c57cc62 
…ic signals with duplicated ids (autowarefoundation#5653)

* fix: add operation to remove traffic signals with duplicated ids

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

* feat: move operation into `crosswalk_traffic_light_estimator`

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>

---------

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miursh miursh miursh approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

@tzhong518 tzhong518 Awaiting requested review from tzhong518

Assignees

@ktro2828 ktro2828

Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktro2828 @miursh