Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): only include forward declaration of lanelet stuff in perception/ header files #4984

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 13, 2023

Description

#4821

Tests performed

tested on awsim

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 13, 2023
@soblin soblin marked this pull request as ready for review September 13, 2023 21:31
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33f62b4) 15.74% compared to head (04cc55f) 15.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4984   +/-   ##
=======================================
  Coverage   15.74%   15.74%           
=======================================
  Files        1587     1587           
  Lines      109796   109796           
  Branches    33730    33730           
=======================================
  Hits        17288    17288           
  Misses      73883    73883           
  Partials    18625    18625           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.74% <ø> (ø) Carriedforward from 33f62b4

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ion/crosswalk_traffic_light_estimator/src/node.cpp 0.00% <ø> (ø)
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <ø> (ø)
...elevation_map_loader/elevation_map_loader_node.hpp 0.00% <ø> (ø)
...ation_map_loader/src/elevation_map_loader_node.cpp 0.00% <ø> (ø)
...map_based_prediction/map_based_prediction_node.hpp 0.00% <ø> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <ø> (ø)
.../include/traffic_light_map_based_detector/node.hpp 0.00% <ø> (ø)
...include/traffic_light_multi_camera_fusion/node.hpp 0.00% <ø> (ø)
...ion/traffic_light_multi_camera_fusion/src/node.cpp 0.00% <ø> (ø)
..._light_occlusion_predictor/occlusion_predictor.hpp 0.00% <ø> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin merged commit 0ef1388 into autowarefoundation:main Sep 14, 2023
@soblin soblin deleted the build-fast3/component/perception/fwd-decl-lanelet branch September 14, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants