Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): minimum object polygon longitudinal margin #4758

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 25, 2023

Description

Added a minimum longitudinal margin for object polygon to generate a drivable area.

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 25, 2023
@takayuki5168 takayuki5168 force-pushed the feat/minimum-object-polygon-margin-for-dynamic-avoidance branch from 644bd68 to d9f8c69 Compare August 28, 2023 02:40
@takayuki5168 takayuki5168 marked this pull request as ready for review August 28, 2023 02:41
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 0.46% and project coverage change: -0.01% ⚠️

Comparison is base (4ed36d2) 15.11% compared to head (0da42d5) 15.10%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4758      +/-   ##
==========================================
- Coverage   15.11%   15.10%   -0.01%     
==========================================
  Files        1568     1568              
  Lines      108137   108158      +21     
  Branches    33188    33214      +26     
==========================================
- Hits        16344    16342       -2     
- Misses      73991    74003      +12     
- Partials    17802    17813      +11     
Flag Coverage Δ *Carryforward flag
differential 13.09% <0.46%> (?)
total 15.13% <ø> (+0.02%) ⬆️ Carriedforward from 4ed36d2

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)
...h_planner/src/scene_module/lane_change/manager.cpp 5.34% <0.00%> (-1.29%) ⬇️
...ocity_virtual_traffic_light_module/src/manager.cpp 0.00% <ø> (ø)
...g/behavior_velocity_walkway_module/src/manager.cpp 24.39% <ø> (+1.13%) ⬆️
...ath_planner/src/scene_module/avoidance/manager.cpp 6.25% <0.94%> (-0.29%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 890d45a into autowarefoundation:main Aug 29, 2023
@takayuki5168 takayuki5168 deleted the feat/minimum-object-polygon-margin-for-dynamic-avoidance branch August 29, 2023 16:49
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 30, 2023
…utowarefoundation#4758)

* feat(dynamic_avoidance): minimum object polygon longitudinal margin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 30, 2023
…utowarefoundation#4758)

* feat(dynamic_avoidance): minimum object polygon longitudinal margin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…utowarefoundation#4758)

* feat(dynamic_avoidance): minimum object polygon longitudinal margin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…utowarefoundation#4758)

* feat(dynamic_avoidance): minimum object polygon longitudinal margin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants