Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic_avoidance): minor changes with bug fix #4567

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 8, 2023

Description

Depends on #4566

  • Fixed a bug of uninitialized previous lat_offset_to_avoid
    • If an object is memorized but lat_offset_to_avoid is not updated, the initial value is 0, and low-pass filter uses it as a previous value, resulting in filtered lat_offset_to_avoid being almost 0.
  • Remove calcPathForObjectPolygon because if the ego does the lane change, the calculated path will change and the result of low-pass filter of lat_offset_to_avoid will be wrong.
    • Reference path in previous module's output can be used instead.
  • modify debug marker for better visibility

Tests performed

planning simulator

Effects on system behavior

minor bug fix of dynamic_avoidance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
@takayuki5168 takayuki5168 changed the title feat(dynamic_avoidance): minor changes with bug fix fix(dynamic_avoidance): minor changes with bug fix Aug 8, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 8, 2023 16:29
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (cdabb78) 14.80% compared to head (7b6af60) 14.87%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4567      +/-   ##
==========================================
+ Coverage   14.80%   14.87%   +0.06%     
==========================================
  Files        1527     1527              
  Lines      105627   107025    +1398     
  Branches    32091    33156    +1065     
==========================================
+ Hits        15639    15920     +281     
- Misses      72919    73696     +777     
- Partials    17069    17409     +340     
Flag Coverage Δ *Carryforward flag
differential 13.15% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from d9feac4

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 9ac8faf into autowarefoundation:main Aug 8, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-minor-changes branch August 8, 2023 18:56
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…n#4567)

* feat(dynamic_avoidance): use hatched road markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add some ros parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): add minor changes

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…n#4567)

* feat(dynamic_avoidance): use hatched road markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add some ros parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): add minor changes

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…n#4567)

* feat(dynamic_avoidance): use hatched road markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add some ros parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): add minor changes

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…n#4567)

* feat(dynamic_avoidance): use hatched road markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add some ros parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove comment

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): add minor changes

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants