Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): add life time to debug markers #4562

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 8, 2023

Description

add life time to debug markers

Related links

Tests performed

psim

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/goal_planner_makers_life_time branch from 6dd8767 to bf8bcbd Compare August 8, 2023 11:41
@kosuke55 kosuke55 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2e5752f) 14.80% compared to head (bf8bcbd) 14.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4562      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1527     1527              
  Lines      105643   105645       +2     
  Branches    32096    32097       +1     
==========================================
  Hits        15642    15642              
- Misses      72925    72927       +2     
  Partials    17076    17076              
Flag Coverage Δ *Carryforward flag
differential 13.11% <0.00%> (?)
total 14.80% <ø> (-0.01%) ⬇️ Carriedforward from 4e68889

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 6.01% <0.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit de7d624 into main Aug 8, 2023
@kosuke55 kosuke55 deleted the feat/goal_planner_makers_life_time branch August 8, 2023 15:45
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2023
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants