Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): plan freespace pull over even if any path has never been found #4561

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 8, 2023

Description

Currently isStuck() return false if any path has never been found before, and do not plan freespace pull over.
In this PR, fix stuck conditions to plan.

Related links

Tests performed

psim

tier4 internal scenario test

miraikan_freespace_pull_over-2023-08-08_19.29.43.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…er been found

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (0dae23f) 14.80% compared to head (ec7e5c8) 14.85%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4561      +/-   ##
==========================================
+ Coverage   14.80%   14.85%   +0.05%     
==========================================
  Files        1527     1527              
  Lines      105594   106125     +531     
  Branches    32065    32495     +430     
==========================================
+ Hits        15636    15768     +132     
- Misses      72887    73119     +232     
- Partials    17071    17238     +167     
Flag Coverage Δ *Carryforward flag
differential 13.14% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from 0dae23f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 6.73% <0.00%> (+0.69%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit f695cb2 into main Aug 8, 2023
@kosuke55 kosuke55 deleted the fix/freespace_pull_over branch August 8, 2023 15:52
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2023
…er been found (autowarefoundation#4561)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…er been found (autowarefoundation#4561)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…er been found (autowarefoundation#4561)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…er been found (autowarefoundation#4561)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants