-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lane_change): add distance check for the lane change acceleration sampling #4556
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4556 +/- ##
==========================================
+ Coverage 14.80% 14.87% +0.07%
==========================================
Files 1527 1527
Lines 105632 105931 +299
Branches 32092 32346 +254
==========================================
+ Hits 15636 15758 +122
- Misses 72924 72965 +41
- Partials 17072 17208 +136
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
… sampling (autowarefoundation#4556) * fix(lane_change): add distance checker in acceleration sampling Signed-off-by: yutaka <purewater0901@gmail.com> * fix format Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
… sampling (autowarefoundation#4556) * fix(lane_change): add distance checker in acceleration sampling Signed-off-by: yutaka <purewater0901@gmail.com> * fix format Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
… sampling (autowarefoundation#4556) * fix(lane_change): add distance checker in acceleration sampling Signed-off-by: yutaka <purewater0901@gmail.com> * fix format Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
Description
The lane change module in the autoware samples longitudinal acceleration values based on the velocity of the ego vehicle and the distance to the current and target lanes. Even though it is supposed to check the distance to the end of current lanes, it does not have that check function. In this PR, I added a check function to measure the distance to the end of lane when sampling longitudinal acceleration.
Scenario test
1581/1588
TIER IV INTERNAL LINK
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.