Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): add distance check for the lane change acceleration sampling #4556

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 8, 2023

Description

The lane change module in the autoware samples longitudinal acceleration values based on the velocity of the ego vehicle and the distance to the current and target lanes. Even though it is supposed to check the distance to the end of current lanes, it does not have that check function. In this PR, I added a check function to measure the distance to the end of lane when sampling longitudinal acceleration.

Scenario test
1581/1588
TIER IV INTERNAL LINK

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
purewater0901 and others added 2 commits August 8, 2023 15:53
Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07% 🎉

Comparison is base (4e68889) 14.80% compared to head (3776b28) 14.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4556      +/-   ##
==========================================
+ Coverage   14.80%   14.87%   +0.07%     
==========================================
  Files        1527     1527              
  Lines      105632   105931     +299     
  Branches    32092    32346     +254     
==========================================
+ Hits        15636    15758     +122     
- Misses      72924    72965      +41     
- Partials    17072    17208     +136     
Flag Coverage Δ *Carryforward flag
differential 13.11% <0.00%> (?)
total 14.80% <ø> (ø) Carriedforward from 4e68889

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...th_planner/src/scene_module/lane_change/normal.cpp 4.34% <0.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purewater0901 purewater0901 merged commit e10db13 into main Aug 8, 2023
@purewater0901 purewater0901 deleted the fix/add-distance-check branch August 8, 2023 14:12
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
… sampling (autowarefoundation#4556)

* fix(lane_change): add distance checker in acceleration sampling

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix format

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
… sampling (autowarefoundation#4556)

* fix(lane_change): add distance checker in acceleration sampling

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix format

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 17, 2023
… sampling (autowarefoundation#4556)

* fix(lane_change): add distance checker in acceleration sampling

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix format

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants