-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crosswalk): set distance even when decision is GO #4551
fix(crosswalk): set distance even when decision is GO #4551
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in terms of the behavior test with Psim
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4551 +/- ##
=======================================
Coverage 14.80% 14.81%
=======================================
Files 1527 1527
Lines 105594 105577 -17
Branches 32065 32052 -13
=======================================
Hits 15636 15636
+ Misses 72887 72869 -18
- Partials 17071 17072 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…tion#4551) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion#4551) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion#4551) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Currently, the distance is not set when the decision is GO in the crosswalk module.
This PR always sets the distance even when the decision is GO.
before
![image](https://private-user-images.githubusercontent.com/20228327/258982777-aa7bd192-4fef-4675-afe3-86fd28d42a68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTIwOTksIm5iZiI6MTczOTM5MTc5OSwicGF0aCI6Ii8yMDIyODMyNy8yNTg5ODI3NzctYWE3YmQxOTItNGZlZi00Njc1LWFmZTMtODZmZDI4ZDQyYTY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIwMjMxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZkODU5N2M2MWVlN2RjZjJhZmQ5M2NkMjNkZmNmOTBiMWMyNWZjNzg2MzQyNTEwY2RmZmJkNjY5MWYyYmVhNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.xltq994I2OabLHRSD9G0owyFkZrAOdgi9AnX55OmlTU)
after
![image](https://private-user-images.githubusercontent.com/20228327/258982796-89b3b30f-3a87-4831-ab8e-67ef22371b49.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTIwOTksIm5iZiI6MTczOTM5MTc5OSwicGF0aCI6Ii8yMDIyODMyNy8yNTg5ODI3OTYtODliM2IzMGYtM2E4Ny00ODMxLWFiOGUtNjdlZjIyMzcxYjQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIwMjMxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhZjU1ZDIwMjlhYWUyMDA0YzdkOTc4OThjZTAxYmM4ODI5Nzg2ZmE2NGI3YmQxZDI1M2QwZTg1MmU2OTFlYjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2yGwVvu1rixaY0toidHXEhkeX832EjZAyOHprD9W0Tk)
Tests performed
planning simulator
Effects on system behavior
Distance is always set in the crosswalk module.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.