Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): set distance even when decision is GO #4551

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 8, 2023

Description

Currently, the distance is not set when the decision is GO in the crosswalk module.
This PR always sets the distance even when the decision is GO.

before
image

after
image

Tests performed

planning simulator

Effects on system behavior

Distance is always set in the crosswalk module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review August 8, 2023 04:15
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
@takayuki5168 takayuki5168 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 8, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of the behavior test with Psim

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0dae23f) 14.80% compared to head (991dc81) 14.81%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4551   +/-   ##
=======================================
  Coverage   14.80%   14.81%           
=======================================
  Files        1527     1527           
  Lines      105594   105577   -17     
  Branches    32065    32052   -13     
=======================================
  Hits        15636    15636           
+ Misses      72887    72869   -18     
- Partials    17071    17072    +1     
Flag Coverage Δ *Carryforward flag
differential 10.58% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from 0dae23f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <ø> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <ø> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk shmpwk merged commit 4e68889 into autowarefoundation:main Aug 8, 2023
@shmpwk shmpwk deleted the fix/crosswalk-distance-when-go-decision branch August 8, 2023 05:38
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2023
…tion#4551)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…tion#4551)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…tion#4551)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants