-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_plannere): do not request when modifed route is received #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
9aee70d
to
566d6e3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4528 +/- ##
=======================================
Coverage 14.85% 14.85%
=======================================
Files 1521 1521
Lines 105224 105228 +4
Branches 32018 32019 +1
=======================================
+ Hits 15627 15629 +2
- Misses 72525 72527 +2
Partials 17072 17072
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Aug 5, 2023
purewater0901
approved these changes
Aug 5, 2023
7 tasks
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2023
…utowarefoundation#4528) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 13, 2023
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…utowarefoundation#4528) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…utowarefoundation#4528) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…utowarefoundation#4528) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
SaltUhey
pushed a commit
to SaltUhey/autoware.universe
that referenced
this pull request
Apr 11, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Oguz <oguzkaganozt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue that when the ego vehicle is stopped and the modified route is received request start planner again
In this PR check not modified route start pose but original route start pose for start planner execution request.
Related links
#4453
Tests performed
psim
tier4 internal sceanrio simulator
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.