Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_plannere): do not request when modifed route is received #4528

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 5, 2023

Description

Fix the issue that when the ego vehicle is stopped and the modified route is received request start planner again
In this PR check not modified route start pose but original route start pose for start planner execution request.

Related links

#4453

Tests performed

psim

tier4 internal sceanrio simulator

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 5, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/start_planner_modified_route_request branch from 9aee70d to 566d6e3 Compare August 5, 2023 05:58
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (4811435) 14.85% compared to head (566d6e3) 14.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4528   +/-   ##
=======================================
  Coverage   14.85%   14.85%           
=======================================
  Files        1521     1521           
  Lines      105224   105228    +4     
  Branches    32018    32019    +1     
=======================================
+ Hits        15627    15629    +2     
- Misses      72525    72527    +2     
  Partials    17072    17072           
Flag Coverage Δ *Carryforward flag
differential 15.85% <50.00%> (?)
total 14.85% <ø> (ø) Carriedforward from 4811435

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
planning/route_handler/src/route_handler.cpp 24.94% <50.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 43e8e16 into main Aug 5, 2023
@kosuke55 kosuke55 deleted the fix/start_planner_modified_route_request branch August 5, 2023 15:26
kosuke55 added a commit that referenced this pull request Aug 8, 2023
kosuke55 added a commit that referenced this pull request Aug 8, 2023
kosuke55 added a commit that referenced this pull request Aug 8, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2023
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
SaltUhey pushed a commit to SaltUhey/autoware.universe that referenced this pull request Apr 11, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: Oguz <oguzkaganozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants