-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk): suppress chattering of GO/STOP decision #4471
Merged
takayuki5168
merged 4 commits into
autowarefoundation:main
from
tier4:feat/crosswalk-chattering-suppresion
Aug 2, 2023
Merged
feat(crosswalk): suppress chattering of GO/STOP decision #4471
takayuki5168
merged 4 commits into
autowarefoundation:main
from
tier4:feat/crosswalk-chattering-suppresion
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
379061e
to
36cd8fe
Compare
4 tasks
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota
approved these changes
Aug 1, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4471 +/- ##
==========================================
- Coverage 14.89% 14.89% -0.01%
==========================================
Files 1520 1520
Lines 104882 104908 +26
Branches 31954 31962 +8
==========================================
Hits 15623 15623
- Misses 72199 72221 +22
- Partials 17060 17064 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
felixf4xu
pushed a commit
to felixf4xu/autoware.universe
that referenced
this pull request
Aug 2, 2023
…ndation#4471) * feat(crosswalk): organize the code Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * suppress chattering Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 9, 2023
…ndation#4471) * feat(crosswalk): organize the code Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * suppress chattering Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…ndation#4471) * feat(crosswalk): organize the code Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * suppress chattering Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Sep 15, 2023
…ndation#4471) * feat(crosswalk): organize the code Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * suppress chattering Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed chattering GO/STOP decision in crosswalk by adding a hysteresis.
Tests performed
Effects on system behavior
Chattering suppression of GO/STOP decision in crosswalk
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.