Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): suppress chattering of GO/STOP decision #4471

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 31, 2023

Description

Fixed chattering GO/STOP decision in crosswalk by adding a hysteresis.

Tests performed

Effects on system behavior

Chattering suppression of GO/STOP decision in crosswalk

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 31, 2023
@takayuki5168 takayuki5168 changed the title Feat/crosswalk chattering suppresion feat(crosswalk) suppress chattering of GO/STOP decision Jul 31, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 1, 2023 08:48
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/crosswalk-chattering-suppresion branch from 379061e to 36cd8fe Compare August 1, 2023 09:45
@takayuki5168 takayuki5168 changed the title feat(crosswalk) suppress chattering of GO/STOP decision feat(crosswalk): suppress chattering of GO/STOP decision Aug 1, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (cd9f5ce) 14.89% compared to head (4afa837) 14.89%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4471      +/-   ##
==========================================
- Coverage   14.89%   14.89%   -0.01%     
==========================================
  Files        1520     1520              
  Lines      104882   104908      +26     
  Branches    31954    31962       +8     
==========================================
  Hits        15623    15623              
- Misses      72199    72221      +22     
- Partials    17060    17064       +4     
Flag Coverage Δ *Carryforward flag
differential 10.81% <0.00%> (?)
total 14.90% <ø> (+<0.01%) ⬆️ Carriedforward from cd9f5ce

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...behavior_velocity_crosswalk_module/src/manager.cpp 12.37% <0.00%> (-0.54%) ⬇️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 0becdc6 into autowarefoundation:main Aug 2, 2023
@takayuki5168 takayuki5168 deleted the feat/crosswalk-chattering-suppresion branch August 2, 2023 00:36
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
…ndation#4471)

* feat(crosswalk): organize the code

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* suppress chattering

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…ndation#4471)

* feat(crosswalk): organize the code

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* suppress chattering

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…ndation#4471)

* feat(crosswalk): organize the code

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* suppress chattering

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 15, 2023
…ndation#4471)

* feat(crosswalk): organize the code

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* suppress chattering

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants