Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): enable avoidance cancel #4398

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 26, 2023

Description

Improve & enable avoidance canceling behavior.

Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#476

Tests performed

  • PASS TIER IV INTERNAL SCENARIOS

Effects on system behavior

Support avoidance canceling behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota marked this pull request as ready for review July 26, 2023 10:18
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 26, 2023
@satoshi-ota satoshi-ota force-pushed the feat/enable-avoidance-cancel branch from 7dd147c to 16c4bd0 Compare July 30, 2023 23:34
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 2, 2023
@satoshi-ota satoshi-ota force-pushed the feat/enable-avoidance-cancel branch from 16c4bd0 to 1eaa026 Compare August 2, 2023 05:16
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cdabb78) 14.80% compared to head (a2583cf) 14.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4398   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1527     1527           
  Lines      105627   105610   -17     
  Branches    32091    32089    -2     
=======================================
  Hits        15639    15639           
+ Misses      72919    72902   -17     
  Partials    17069    17069           
Flag Coverage Δ *Carryforward flag
differential 13.08% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from cdabb78

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 8.33% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 12.09% <0.00%> (+0.06%) ⬆️
...ath_planner/src/scene_module/avoidance/manager.cpp 7.07% <0.00%> (+0.03%) ⬆️
...h_planner/src/scene_module/lane_change/manager.cpp 7.64% <ø> (+0.09%) ⬆️
...er/src/utils/drivable_area_expansion/expansion.cpp 32.11% <0.00%> (-0.30%) ⬇️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <ø> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -139,67 +139,59 @@ bool AvoidanceModule::isExecutionReady() const
ModuleStatus AvoidanceModule::updateState()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orgnized well!

@@ -93,7 +93,7 @@ struct AvoidanceParameters
bool use_opposite_lane{true};

// enable update path when if detected objects on planner data is gone.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated breif description and fix param name in doc.

@satoshi-ota satoshi-ota force-pushed the feat/enable-avoidance-cancel branch from 1eaa026 to 081ee5f Compare August 8, 2023 06:47
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/enable-avoidance-cancel branch from 081ee5f to a2583cf Compare August 8, 2023 06:56
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 8, 2023
@satoshi-ota satoshi-ota merged commit 1f91c83 into autowarefoundation:main Aug 8, 2023
@satoshi-ota satoshi-ota deleted the feat/enable-avoidance-cancel branch August 8, 2023 13:08
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants