-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): enable avoidance cancel #4398
feat(avoidance): enable avoidance cancel #4398
Conversation
7dd147c
to
16c4bd0
Compare
16c4bd0
to
1eaa026
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
=======================================
Coverage 14.80% 14.80%
=======================================
Files 1527 1527
Lines 105627 105610 -17
Branches 32091 32089 -2
=======================================
Hits 15639 15639
+ Misses 72919 72902 -17
Partials 17069 17069
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -139,67 +139,59 @@ bool AvoidanceModule::isExecutionReady() const | |||
ModuleStatus AvoidanceModule::updateState() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orgnized well!
@@ -93,7 +93,7 @@ struct AvoidanceParameters | |||
bool use_opposite_lane{true}; | |||
|
|||
// enable update path when if detected objects on planner data is gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated breif description and fix param name in doc.
1eaa026
to
081ee5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
081ee5f
to
a2583cf
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Improve & enable avoidance canceling behavior.
Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#476
Tests performed
Effects on system behavior
Support avoidance canceling behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.