Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spell-check-partial): enable for unchanged files #4383

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

HansRobo
Copy link
Member

Description

Until now, spell-check-partial checked changed files only.
But especially when you update update the scope of spell-check-partial, the result of spell-check-partial is not appropriate.
To resolve this problem, it is reasonable to check all files in spell-check-partial.
In most cases, spell-check-partial checks more files than needed, but that's not a problem since the files in scope of spell-check-partial already have no errors.

Tests performed

  • pass spell-check-partial workflow

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HansRobo HansRobo requested a review from kminoda July 24, 2023 11:50
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 24, 2023
@HansRobo HansRobo enabled auto-merge (squash) July 24, 2023 12:07
@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 24, 2023
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo HansRobo merged commit e2e80c8 into main Jul 25, 2023
@HansRobo HansRobo deleted the HansRobo-patch-1 branch July 25, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants