Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add error handling for null output #4352

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 21, 2023

Description

Add an error handling when the module output is null.

Without this code, some modules may die due to invalid memory access.

Tests performed

Run psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: +0.03% 🎉

Comparison is base (04ea73c) 15.03% compared to head (093113a) 15.06%.

❗ Current head 093113a differs from pull request most recent head a73bde2. Consider uploading reports for the commit a73bde2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4352      +/-   ##
==========================================
+ Coverage   15.03%   15.06%   +0.03%     
==========================================
  Files        1508     1512       +4     
  Lines      103879   106302    +2423     
  Branches    31730    33577    +1847     
==========================================
+ Hits        15614    16011     +397     
- Misses      71233    72920    +1687     
- Partials    17032    17371     +339     
Flag Coverage Δ *Carryforward flag
differential 13.51% <12.50%> (?)
total 15.09% <ø> (+0.05%) ⬆️ Carriedforward from 0399032

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../include/behavior_path_planner/planner_manager.hpp 18.86% <ø> (ø)
...ning/behavior_path_planner/src/planner_manager.cpp 19.93% <12.50%> (+0.15%) ⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe changed the title feat: add curvature consideration in shift start feat(behavior_path_planner): add curvature consideration in shift start Jul 21, 2023
@kosuke55
Copy link
Contributor

the PR title is wrong?

@TakaHoribe TakaHoribe changed the title feat(behavior_path_planner): add curvature consideration in shift start feat(behavior_path_planner): add error handling for null output Jul 21, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 24, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the bpp-error-handling branch from 093113a to a73bde2 Compare July 25, 2023 01:52
@TakaHoribe TakaHoribe merged commit 859975a into autowarefoundation:main Jul 25, 2023
@TakaHoribe TakaHoribe deleted the bpp-error-handling branch July 25, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants