Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_cmd_gate): auto mode check #4333

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 19, 2023

Description

Fix the condition for the autonomous mode check

Tests performed

tested on a real vehicle

Effects on system behavior

Behavior is improved when "autoware control is off but still operation mode is in AUTONOMOUS".

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from tkimura4 as a code owner July 19, 2023 04:59
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e1cd2c) 14.17% compared to head (e4f8153) 14.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4333   +/-   ##
=======================================
  Coverage   14.17%   14.18%           
=======================================
  Files        1601     1601           
  Lines      110209   110148   -61     
  Branches    31606    31580   -26     
=======================================
- Hits        15624    15620    -4     
+ Misses      77598    77552   -46     
+ Partials    16987    16976   -11     
Flag Coverage Δ *Carryforward flag
differential 19.12% <0.00%> (?)
total 14.18% <ø> (+<0.01%) ⬆️ Carriedforward from 4e1cd2c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 77.77% <0.00%> (-9.73%) ⬇️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.28% <0.00%> (-0.01%) ⬇️
...oc_common/src/ground_server/ground_server_core.cpp 0.00% <ø> (ø)
..._common/src/ll2_decomposer/ll2_decomposer_core.cpp 0.00% <ø> (ø)
...processing/graph_segment/similar_area_searcher.hpp 0.00% <ø> (ø)
...essing/src/graph_segment/similar_area_searcher.cpp 0.00% <ø> (ø)
...cessing/src/segment_filter/segment_filter_core.cpp 0.00% <ø> (ø)
...amera_corrector/camera_particle_corrector_core.cpp 0.00% <ø> (ø)
.../yabloc/yabloc_particle_filter/src/common/mean.cpp 0.00% <ø> (ø)
...ticle_filter/src/correction/abstract_corrector.cpp 0.00% <ø> (ø)
... and 17 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 enabled auto-merge (squash) July 19, 2023 05:26
@tkimura4 tkimura4 merged commit e5f9584 into autowarefoundation:main Jul 19, 2023
@tkimura4 tkimura4 deleted the fix-gate-mode branch July 19, 2023 05:35
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants