Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_cmd_gate): fix slow start #4323

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jul 18, 2023

Description

In the "vehicle_cmd_gate" module, the current practice is to use the actual longitudinal state of the vehicle (accel=0, speed=0) as the previous command value during a stop. However, this can occasionally lead to a decrease in the commanded acceleration, resulting in a slower start. So, I have made a modification to utilize the larger of the previous command value or the actual longitudinal state of the vehicle as the previous command value.

Before:
image

After:
The value of /control/command/control_cmd/longitudinal/acceleration has been improved to increase smoothly.

image

Related links

Tests performed

Tested by rosbag and logging_simulator (See description)

Notes for reviewers

none

Interface changes

none

Effects on system behavior

Improved departure delays

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from TakaHoribe as a code owner July 18, 2023 12:57
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jul 18, 2023
@tkimura4
Copy link
Contributor Author

TODO: consider reverse driving

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.99 🎉

Comparison is base (665281e) 14.17% compared to head (0929f74) 15.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4323      +/-   ##
==========================================
+ Coverage   14.17%   15.17%   +0.99%     
==========================================
  Files        1601     1493     -108     
  Lines      110214   102875    -7339     
  Branches    31602    31547      -55     
==========================================
- Hits        15623    15610      -13     
+ Misses      77603    70314    -7289     
+ Partials    16988    16951      -37     
Flag Coverage Δ *Carryforward flag
differential 19.16% <0.00%> (?)
total 15.17% <ø> (+0.99%) ⬆️ Carriedforward from a9a3fee

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ontrol/vehicle_cmd_gate/src/vehicle_cmd_filter.hpp 77.77% <0.00%> (-9.73%) ⬇️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.28% <0.00%> (-0.01%) ⬇️

... and 115 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 enabled auto-merge (squash) July 19, 2023 02:51
@tkimura4 tkimura4 merged commit 61cde1d into autowarefoundation:main Jul 19, 2023
@tkimura4 tkimura4 deleted the fix/slow_start branch July 19, 2023 03:13
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jul 19, 2023
* fix(vehicle_cmd_gate): fix slow start

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: consider reverse driving

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 21, 2023
* fix(vehicle_cmd_gate): fix slow start

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: consider reverse driving

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Jul 24, 2023
* fix(vehicle_cmd_gate): fix slow start

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: consider reverse driving

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants