-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vehicle_cmd_gate): fix slow start #4323
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
TODO: consider reverse driving |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4323 +/- ##
==========================================
+ Coverage 14.17% 15.17% +0.99%
==========================================
Files 1601 1493 -108
Lines 110214 102875 -7339
Branches 31602 31547 -55
==========================================
- Hits 15623 15610 -13
+ Misses 77603 70314 -7289
+ Partials 16988 16951 -37
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* fix(vehicle_cmd_gate): fix slow start Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * feat: consider reverse driving Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* fix(vehicle_cmd_gate): fix slow start Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * feat: consider reverse driving Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* fix(vehicle_cmd_gate): fix slow start Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * feat: consider reverse driving Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Description
In the "vehicle_cmd_gate" module, the current practice is to use the actual longitudinal state of the vehicle (accel=0, speed=0) as the previous command value during a stop. However, this can occasionally lead to a decrease in the commanded acceleration, resulting in a slower start. So, I have made a modification to utilize the larger of the previous command value or the actual longitudinal state of the vehicle as the previous command value.
Before:
![image](https://private-user-images.githubusercontent.com/59680180/254268804-fa958d11-f846-43ad-9bae-c665730128a0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzYzNTEsIm5iZiI6MTczOTY3NjA1MSwicGF0aCI6Ii81OTY4MDE4MC8yNTQyNjg4MDQtZmE5NThkMTEtZjg0Ni00M2FkLTliYWUtYzY2NTczMDEyOGEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAzMjA1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5YWE4MDRkYmU1OTJiNDQxZGVhYTg4YTBiMDY0N2Y0NTExMTI5Yjc5OWRjOGM3NWE5NWM0ZjY4OTkyOGYyOWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.eunnQPKjqi430y5bk3RApO45V_GPzZ0-pTvYnt8khM8)
After:
The value of
/control/command/control_cmd/longitudinal/acceleration
has been improved to increase smoothly.Related links
Tests performed
Tested by rosbag and logging_simulator (See description)
Notes for reviewers
none
Interface changes
none
Effects on system behavior
Improved departure delays
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.