Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): fix lateral calculations #4292

Merged

Conversation

beyzanurkaya
Copy link
Contributor

@beyzanurkaya beyzanurkaya commented Jul 16, 2023

Description

This PR is to add the missing functionality of fixing lateral calculations in obstacle_avoidance_planner since refactoring done in #2796 .

Related links

closes #4190

Notes for reviewers

Original PR : #2878
Refactoring PR : #2796

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya beyzanurkaya self-assigned this Jul 16, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 16, 2023
@beyzanurkaya beyzanurkaya changed the title consider right/left overhang for lateral calculations fix(obstacle_avoidance_planner): fix lateral calculations Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (c65bccd) 14.77% compared to head (f0311e0) 14.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4292   +/-   ##
=======================================
  Coverage   14.77%   14.77%           
=======================================
  Files        1663     1663           
  Lines      115168   115181   +13     
  Branches    35530    35531    +1     
=======================================
+ Hits        17015    17020    +5     
- Misses      78937    78944    +7     
- Partials    19216    19217    +1     
Flag Coverage Δ *Carryforward flag
differential 36.60% <32.25%> (?)
total 14.77% <ø> (-0.01%) ⬇️ Carriedforward from c65bccd

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 39.88% <28.57%> (-0.08%) ⬇️
...ng/obstacle_avoidance_planner/src/debug_marker.cpp 16.12% <33.33%> (+1.43%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beyzanurkaya beyzanurkaya force-pushed the fix/fix-lateral-calculation branch from b9ab425 to 4af9524 Compare July 19, 2023 14:19
@beyzanurkaya beyzanurkaya requested a review from mehmetdogru July 20, 2023 11:22
@beyzanurkaya beyzanurkaya marked this pull request as draft July 21, 2023 08:05
@beyzanurkaya beyzanurkaya force-pushed the fix/fix-lateral-calculation branch from 19d3c39 to 9e62b0e Compare July 24, 2023 23:21
@stale
Copy link

stale bot commented Sep 23, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 23, 2023
@beyzanurkaya beyzanurkaya force-pushed the fix/fix-lateral-calculation branch from eb88b32 to cfea5d5 Compare October 17, 2023 12:18
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Oct 17, 2023
@beyzanurkaya beyzanurkaya marked this pull request as ready for review October 17, 2023 12:19
@beyzanurkaya
Copy link
Contributor Author

@takayuki5168 Sorry for the delay, could you review this PR?

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@beyzanurkaya beyzanurkaya added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 17, 2023
@beyzanurkaya beyzanurkaya force-pushed the fix/fix-lateral-calculation branch 3 times, most recently from decbb41 to 612af4d Compare October 17, 2023 15:19
@beyzanurkaya beyzanurkaya force-pushed the fix/fix-lateral-calculation branch from 612af4d to 2ffd93c Compare October 17, 2023 15:19
@beyzanurkaya beyzanurkaya merged commit b3bdedc into autowarefoundation:main Oct 17, 2023
@beyzanurkaya beyzanurkaya deleted the fix/fix-lateral-calculation branch October 17, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding missing PRs to obstacle_avoidance_planner since code refactoring
2 participants