-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle_avoidance_planner): fix lateral calculations #4292
fix(obstacle_avoidance_planner): fix lateral calculations #4292
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4292 +/- ##
=======================================
Coverage 14.77% 14.77%
=======================================
Files 1663 1663
Lines 115168 115181 +13
Branches 35530 35531 +1
=======================================
+ Hits 17015 17020 +5
- Misses 78937 78944 +7
- Partials 19216 19217 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b9ab425
to
4af9524
Compare
19d3c39
to
9e62b0e
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
eb88b32
to
cfea5d5
Compare
@takayuki5168 Sorry for the delay, could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
decbb41
to
612af4d
Compare
Signed-off-by: beyza <bnk@leodrive.ai>
612af4d
to
2ffd93c
Compare
Description
This PR is to add the missing functionality of fixing lateral calculations in
obstacle_avoidance_planner
since refactoring done in #2796 .Related links
closes #4190
Notes for reviewers
Original PR : #2878
Refactoring PR : #2796
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.