refactor(ndt_scan_matcher): fixed as pointed out by clang-tidy #4270
Conversation
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4270 +/- ##
==========================================
- Coverage 15.21% 14.21% -1.00%
==========================================
Files 1489 1597 +108
Lines 102642 109834 +7192
Branches 31523 31485 -38
==========================================
Hits 15613 15613
- Misses 70080 77277 +7197
+ Partials 16949 16944 -5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
The clang-tidy check is still in progress, but it seems that another lint-check is causing an error due to the effect of "NOLINT" that was added to avoid clang-tidy warnings. I didn't realize there were two types of lint-check running. I'll fix that later. |
|
Thank you! Let us know if the required CIs are fixed so that we can start reviewing 👍 (Maybe better to make it a draft until then) |
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
| void publish_marker( | ||
| const rclcpp::Time & sensor_ros_time, const std::vector<geometry_msgs::msg::Pose> & pose_array); | ||
| void publish_initial_to_result_distances( | ||
| const rclcpp::Time & sensor_ros_msg, const geometry_msgs::msg::Pose & result_pose_msg, | ||
| const rclcpp::Time & sensor_ros_time, const geometry_msgs::msg::Pose & result_pose_msg, |
There was a problem hiding this comment.
Thank you so much for finding this...!
|
I found that spell-check failed due to
Now, it passes spell-check-differential completely. |
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Description
I modified
according to the warnings from clang-tidy.
Tests performed
I have checked the operation of the following three
Effects on system behavior
There are no changes about behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.