Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner_common): add depend for inline functions #4244

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 11, 2023

Description

Add dependency for inline functions, which I removed in #4229 by mistake.

Without this PR, some behavior_velocity_planner modules die.
image

Tests performed

Run psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3ae0b00) 14.21% compared to head (9d8bf36) 14.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4244   +/-   ##
=======================================
  Coverage   14.21%   14.21%           
=======================================
  Files        1597     1597           
  Lines      109829   109829           
  Branches    31503    31503           
=======================================
  Hits        15609    15609           
  Misses      77272    77272           
  Partials    16948    16948           
Flag Coverage Δ *Carryforward flag
differential 9.57% <ø> (?)
total 14.21% <ø> (ø) Carriedforward from 3ae0b00

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ocity_planner_common/utilization/arc_lane_util.hpp 75.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit 3b0ef6a into autowarefoundation:main Jul 12, 2023
@TakaHoribe TakaHoribe deleted the fix-depend-bvp branch July 12, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants